make sure to provide an upper bound for max inputs when adjusting fees #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
added
the
RESOLVING ISSUE
KtorZ
force-pushed
the
KtorZ/2032/fee-estimation-slow
branch
2 times, most recently
from
d4b0fd9
to
89f8a06
Compare
In order to prevent transactions from becoming too big, we compute an estimated maximum number of inputs that can be selected. This is well respected by coin selection algorithms but was disregarded by the fee adjustment function which would basically pick UTxO until it has either covered fees or depleted the entire UTxO. Although in practice it should be rarely necessary to pick more than 1 extra input, there are edge-cases where we may need many (especially in wallets with a lot of dust). Picking inputs without any upper bound could cause a transaction to go beyond an acceptable size, and be later rejected.
KtorZ
force-pushed
the
KtorZ/TODO/fix-fee-adjustment-no-upper-bound
branch
from
28a9f52
to
84d5378
Compare
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
KtorZ/TODO/fix-fee-adjustment-no-upper-bound
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
TODO (discovered as part of the slow fee estimation investigation, this is slightly related but actually a bug).
Overview
In order to prevent transactions from becoming too big, we compute an estimated maximum number of inputs that can be selected. This is well respected by coin selection algorithms but was disregarded by the fee adjustment function which would basically pick UTxO until it has either covered fees or depleted the entire UTxO. Although in practice it should be rarely necessary to pick more than 1 extra input, there are edge-cases where we may need many (especially in wallets with a lot of dust). Picking inputs without any upper bound could cause a transaction to go beyond an acceptable size, and be later rejected.
Comments