Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and cover 'Buildable' instances #222

Merged
merged 2 commits into from
May 6, 2019
Merged

Review and cover 'Buildable' instances #222

merged 2 commits into from
May 6, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented May 6, 2019

Issue Number

#220

Overview

  • I have reviewed some 'Buildable' instances to make them more consistent between each others
  • I have added some unit tests to actually check the shape of the produced output and have some regression "protection" there.
  • Also some minor comment additions here and there,

Comments

@KtorZ KtorZ requested a review from piotr-iohk May 6, 2019 13:04
@KtorZ KtorZ self-assigned this May 6, 2019
@KtorZ KtorZ mentioned this pull request May 6, 2019
Closed
9 tasks
piotr-iohk
piotr-iohk approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@KtorZ KtorZ force-pushed the KtorZ/buildable-testing branch from 0ede7bb to d00d697 Compare May 6, 2019 14:39
@KtorZ KtorZ merged commit 637b527 into master May 6, 2019
@KtorZ KtorZ deleted the KtorZ/buildable-testing branch May 6, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-iohk piotr-iohk piotr-iohk approved these changes

Assignees

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KtorZ @piotr-iohk