Code Coverage for integration tests scenarios #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So I suppose that the downside is that we no longer have a |
|
@piotr-iohk Indeed, but that's something we can re-enable fairly easily to make sure we still have some automated verification for this. |
|
Should I maybe do it in this PR directly? |
sure, why not :) |
piotr-iohk
approved these changes
May 7, 2019
KtorZ
force-pushed
the
KtorZ/220/debt-coverage-integration-tests
branch
from
3aecf52
to
fc9df49
Compare
|
@piotr-iohk Added a "Cardano.LauncherSpec" which just call the launcher using the command-line, and wait for a bit. If the launcher crashes or doesn't start, the test fails. |
piotr-iohk
reviewed
May 7, 2019
| cancel handle | ||
| Right _ -> | ||
| expectationFailure | ||
| "cardano-wallet-launcher isn't supposed to terminates. \ |
Before, we ran this in a separate process which, as a major downside, has been escaping any form of coverage measurement. Having it ran in another _thread_ solves this problem
KtorZ
force-pushed
the
KtorZ/220/debt-coverage-integration-tests
branch
from
fc9df49
to
b053b11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#220
Overview
Comments
Note: I've also removed the 'Local' network target as it's not really a thing and isn't much use anyway.