Fix API definition for addresses (which fix request routing for GET /v2/wallets/{walletId}) #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wallets/{walletId})
8 tasks
alecalve
pushed a commit
to alecalve/cardano-sl
that referenced
this pull request
May 16, 2019
4020: Prepare wallet backend 1.5 release r=KtorZ a=KtorZ ## Description <!--- A brief description of this PR and the problem is trying to solve --> After we split the wallet backend development on its own repo, we wanted to setup a submodule from 'cardano-sl' to 'cardano-wallet' to keep the former up-to-date with what was happening on 'cardano-wallet'. This was unpractical to maintain and decided to revert this and instead, duplicate and freeze the source code of 'cardano-wallet' on sl (only updating when changes required so). When we froze, it wasn't yet clear what features were going to be released in 1.5. Therefore, the code currently on 'cardano-sl' includes stuff it should. This commit removes them. This also seemingly fixes acid-state migration from 1.4 to current develop (1.5 target). ## Linked issue <!--- Put here the relevant issue from YouTrack --> cardano-foundation/cardano-wallet#230 Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#229
Overview
Comments
Whoops 🤷♂️