Review CLI interface & implement --version #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
reviewed
May 7, 2019
exe/wallet/Main.hs
Outdated
| cardano-wallet wallet list [--port=INT] | ||
| cardano-wallet wallet get [--port=INT] --wallet-id=STRING | ||
| cardano-wallet wallet create [--port=INT] --name=STRING [--address-pool-gap=INT] | ||
| cardano-wallet wallet delete [--port=INT] --id=STRING |
There was a problem hiding this comment.
Yes... or cardano-wallet wallet get [--port=INT] --id=STRING :)
There was a problem hiding this comment.
Ah! That's what you meant 😄 ... I've just made this a positional argument actually (as discussed in the ticket), so I'll push on top of this commit.
piotr-iohk
reviewed
May 7, 2019
| @@ -182,6 +192,18 @@ exec manager args | |||
| wId <- args `parseArg` longOption "id" | |||
| runClient $ void $ deleteWallet (ApiT wId) | |||
|
|
|||
| | args `isPresent` longOption "version" = do | |||
| let cabal = B8.unpack $(embedFile "cardano-wallet.cabal") | |||
There was a problem hiding this comment.
we're not shipping cardano-wallet.cabal, so it wouldn't work, would it? :/
There was a problem hiding this comment.
It does, the file is embedded at compile-time. This won't even compile without the file.
8 tasks
KtorZ
force-pushed
the
KtorZ/229/review-cli-interfaces
branch
from
e1776f7
to
af0a8cb
Compare
akegalj
approved these changes
May 7, 2019
| port <- args `parseArg` longOption "port" | ||
| let env = mkClientEnv manager (BaseUrl Http "localhost" port "") | ||
| res <- runClientM cmd env | ||
| case res of | ||
| Left (FailureResponse r) | responseStatusCode r == status404 -> do | ||
| let typ = T.pack $ tyConName $ typeRepTyCon $ typeRep $ Proxy @b |
There was a problem hiding this comment.
I've added a similar one for status409 :: Conflict for already existing resources.
KtorZ
force-pushed
the
KtorZ/229/review-cli-interfaces
branch
from
3c3b4df
to
93e6a65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#229
Overview
--versionusing the version from thecardano-wallet.cabal[--port]option to the delete wallet command404and409errorswalletIda positional argument (rather than being a option)PUT /v2/wallets/{walletId}command in the CLI definitionDELETE /v2/wallets/{walletId}to display nothing but a confirmation or error message (was displaying an empty array before)Comments