Add detailed validation of metadata-server responses #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
reviewed
Feb 11, 2021
| | otherwise = Left $ "Length must be no more than " ++ show maxLen ++ " bytes, got " ++ show len | ||
| where | ||
| len = BS.length $ unAssetLogo logo | ||
| maxLen = 87400 |
There was a problem hiding this comment.
maxLen should be 65535 (64KB) here right? 87400 is the max-length of the base64-encoded data payload.
KtorZ
reviewed
Feb 11, 2021
rvl
force-pushed
the
rvl/adp-413/metadata-validation
branch
from
b168fd6
to
066e6a2
Compare
Base automatically changed from
KtorZ/ADP-413/non-required-well-known-properties
to
master
February 11, 2021 11:18
KtorZ
force-pushed
the
rvl/adp-413/metadata-validation
branch
from
066e6a2
to
53ca900
Compare
KtorZ
approved these changes
Feb 11, 2021
KtorZ
force-pushed
the
rvl/adp-413/metadata-validation
branch
2 times, most recently
from
f9a4209
to
3ba56ce
Compare
rvl
force-pushed
the
rvl/adp-413/metadata-validation
branch
from
3ba56ce
to
4f2119b
Compare
rvl
force-pushed
the
rvl/adp-413/metadata-validation
branch
from
4f2119b
to
c6a0486
Compare
It will only print the logs if the test fails.
rvl
force-pushed
the
rvl/adp-413/metadata-validation
branch
from
d39e901
to
a5cdbbe
Compare
rvl
force-pushed
the
rvl/adp-413/metadata-validation
branch
from
a5cdbbe
to
7e3ea34
Compare
|
It was still draft because there were test failures, which I eventually found were because I didn't update the mock metadata server after changing the types. bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 12, 2021
2509: Add detailed validation of metadata-server responses r=rvl a=rvl ### Issue Number ADP-413 ### Overview - Add detailed validation of metadata-server responses - Adds more json parsing and validation tests - Fixes the mock metadata server so that it supports invalid metadata, and only returns properties requested, rather than all properties available. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
|
Build failed: It failed on weeder, doh! Everything else passed. #expected |
KtorZ
pushed a commit
that referenced
this pull request
Feb 12, 2021
…lidation Add detailed validation of metadata-server responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-413
Overview