Shared wallets testing #2619

piotr-iohk · 2021-04-21T12:22:03Z

Issue Number

ADP-660

Overview

I have added e2e tests using also cardano-addresses from the bundle
marked shared eps as experimental for the time being

Comments

rvl

Great

rvl · 2021-04-22T03:07:48Z

test/e2e/Gemfile

@@ -1,6 +1,7 @@
 source 'https://rubygems.org'

-gem 'cardano_wallet', '0.3.2'
+gem 'cardano_wallet', '0.3.4'


I like pinning of all the other deps, but this one could have pessimistic versioning, because we control it.

rvl · 2021-04-22T03:18:25Z

test/e2e/Gemfile

@@ -1,6 +1,7 @@
 source 'https://rubygems.org'

-gem 'cardano_wallet', '0.3.2'
+gem 'cardano_wallet', '0.3.4'
+# gem 'cardano_wallet', path: "~/wb/cardano_wallet"


Does gem provide a command to link in a local package for development?
I remember that python pip had the pip install --editable ~/project option..

It seems there are other options https://stackoverflow.com/questions/26876000/ruby-gem-equivalent-of-pip-install-e, this being one of them.

rvl · 2021-04-22T04:05:41Z

test/e2e/helpers/utils.rb

+      bins = absolute_path ENV['TESTS_E2E_BINDIR']
+      bins = (bins == '' ? bins : "#{bins}/")
+      bins = '' if is_win?


The standard way of locating executables is by using the PATH environment variable.
We should almost never need to add paths when spawning commands.
The test framework could add TESTS_E2E_BINDIR onto the front of PATH at startup.

rvl · 2021-04-22T04:07:10Z

test/e2e/spec/shelley_spec.rb

@@ -2,7 +2,7 @@

  describe CardanoWallet::Shelley::Wallets do

-    before(:each) do
+    after(:each) do


rvl · 2021-04-22T04:09:41Z

test/e2e/spec/spec_helper.rb

+  pscript = JSON.parse(script_template)
+  dscript = JSON.parse(script_template)


The json conversion step isn't needed, is it?
The script template could stay as a ruby dict.

rvl · 2021-04-22T05:07:57Z

specifications/api/swagger.yaml

@@ -5137,7 +5137,7 @@ paths:
      tags: ["Shared Wallets"]
      summary: Create
      description: |
-        <p align="right">status: <strong>stable</strong></p>
+        <p align="right">status: <strong>experimental</strong></p>


We should probably upgrade this to "under development", just to leave no doubt.

…E_BINDIR to point to executables to test

…the PATH but absolute path is still needed when starting node and wallet as services on Win.

…rings

…ng all the blocks for several minutes so wallet is not able to connect within 180s timeout. The only way to clear GH cache is to change key.

paweljakubas · 2021-04-23T09:56:11Z

test/e2e/spec/shared_spec.rb

+
+        m24 = mnemonic_sentence(24)
+        acc_ix = '0H'
+        acc_xpub = cardano_address_get_acc_xpub(m24, "1852H/1815H/#{acc_ix}")


it is going to be 1854H very soon - just indicating

paweljakubas

sweat

piotr-iohk · 2021-04-23T09:58:48Z

bors r+

2619: Shared wallets testing r=piotr-iohk a=piotr-iohk # Issue Number ADP-660 # Overview  - [ ] I have added e2e tests using also cardano-addresses from the bundle - [ ] marked shared eps as experimental for the time being # Comments   Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>

iohk-bors · 2021-04-23T10:08:51Z

Build failed:

ci/hydra-build:required

  test/unit/Cardano/Wallet/Shelley/TransactionSpec.hs:442:9:
  1) Cardano.Wallet.Shelley.Transaction, estimateMaxNumberOfInputs for ByronKey, more outputs ==> less inputs
       Timeout of 300000 microseconds exceeded. (after 814 tests):
         Quantity {getQuantity = 1205}
         NonEmpty {getNonEmpty = [TxOut {address = Address {unAddress = "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL"}, tokens = TokenBundle {coin = Coin 6, tokens = TokenMap (fromList [(UnsafeTokenPolicyId (Hash "\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170"),NonEmptyMap {least = (UnsafeTokenName "TokenA",TokenQuantity 9), rest = fromList []}),(UnsafeTokenPolicyId (Hash "\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204"),NonEmptyMap {least = (UnsafeTokenName "TokenA",TokenQuantity 2), rest = fromList []}),(UnsafeTokenPolicyId (Hash "\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221"),NonEmptyMap {least = (UnsafeTokenName "TokenD",TokenQuantity 2), rest = fromList []})])}},TxOut {address = Address {unAddress = "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL"}, tokens = TokenBundle {coin = Coin 3, tokens = TokenMap (fromList [])}},TxOut {address = Address {unAddress = "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL"}, tokens = TokenBundle {coin = Coin 7, tokens = TokenMap (fromList [(UnsafeTokenPolicyId (Hash "\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170"),NonEmptyMap {least = (UnsafeTokenName "TokenC",TokenQuantity 7), rest = fromList [(UnsafeTokenName "TokenD",TokenQuantity 7)]}),(UnsafeTokenPolicyId (Hash "\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187"),NonEmptyMap {least = (UnsafeTokenName "TokenB",TokenQuantity 10), rest = fromList []}),(UnsafeTokenPolicyId (Hash "\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221"),NonEmptyMap {least = (UnsafeTokenName "TokenD",TokenQuantity 10), rest = fromList []})])}},TxOut {address = Address {unAddress = "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL"}, tokens = TokenBundle {coin = Coin 1, tokens = TokenMap (fromList [(UnsafeTokenPolicyId (Hash "\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187"),NonEmptyMap {least = (UnsafeTokenName "TokenB",TokenQuantity 7), rest = fromList []})])}},TxOut {address = Address {unAddress = "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL"}, tokens = TokenBundle {coin = Coin 2, tokens = TokenMap (fromList [])}},TxOut {address = Address {unAddress = "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL"}, tokens = TokenBundle {coin = Coin 4, tokens = TokenMap (fromList [(UnsafeTokenPolicyId (Hash "\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221"),NonEmptyMap {least = (UnsafeTokenName "TokenA",TokenQuantity 9), rest = fromList []})])}},TxOut {address = Address {unAddress = "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL"}, tokens = TokenBundle {coin = Coin 10, tokens = TokenMap (fromList [])}},TxOut {address = Address {unAddress = "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL"}, tokens = TokenBundle {coin = Coin 5, tokens = TokenMap (fromList [(UnsafeTokenPolicyId (Hash "\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221"),NonEmptyMap {least = (UnsafeTokenName "TokenA",TokenQuantity 4), rest = fromList []})])}},TxOut {address = Address {unAddress = "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL"}, tokens = TokenBundle {coin = Coin 1, tokens = TokenMap (fromList [(UnsafeTokenPolicyId (Hash "\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221\221"),NonEmptyMap {least = (UnsafeTokenName "TokenD",TokenQuantity 6), rest = fromList []})])}},TxOut {address = Address {unAddress = "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL"}, tokens = TokenBundle {coin = Coin 2, tokens = TokenMap (fromList [(UnsafeTokenPolicyId (Hash "\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170"),NonEmptyMap {least = (UnsafeTokenName "TokenA",TokenQuantity 2), rest = fromList []}),(UnsafeTokenPolicyId (Hash "\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187"),NonEmptyMap {least = (UnsafeTokenName "TokenA",TokenQuantity 5), rest = fromList [(UnsafeTokenName "TokenB",TokenQuantity 16),(UnsafeTokenName "TokenC",TokenQuantity 1)]})])}},TxOut {address = Address {unAddress = "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL"}, tokens = TokenBundle {coin = Coin 5, tokens = TokenMap (fromList [])}},TxOut {address = Address {unAddress = "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL"}, tokens = TokenBundle {coin = Coin 10, tokens = TokenMap (fromList [])}},TxOut {address = Address {unAddress = "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL"}, tokens = TokenBundle {coin = Coin 4, tokens = TokenMap (fromList [(UnsafeTokenPolicyId (Hash "\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170\170"),NonEmptyMap {least = (UnsafeTokenName "TokenD",TokenQuantity 9), rest = fromList []}),(UnsafeTokenPolicyId (Hash "\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187\187"),NonEmptyMap {least = (UnsafeTokenName "TokenA",TokenQuantity 10), rest = fromList []}),(UnsafeTokenPolicyId (Hash "\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204\204"),NonEmptyMap {least = (UnsafeTokenName "TokenA",TokenQuantity 4), rest = fromList [(UnsafeTokenName "TokenD",TokenQuantity 2)]})])}}]}

  To rerun use: --match "/Cardano.Wallet.Shelley.Transaction/estimateMaxNumberOfInputs for ByronKey/more outputs ==> less inputs/"

Randomized with seed 228446626

#2522

piotr-iohk · 2021-04-23T12:20:12Z

bors r+

2619: Shared wallets testing r=piotr-iohk a=piotr-iohk # Issue Number ADP-660 # Overview  - [ ] I have added e2e tests using also cardano-addresses from the bundle - [ ] marked shared eps as experimental for the time being # Comments   Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>

iohk-bors · 2021-04-23T13:14:23Z

Build failed:

ci/hydra-build:required

  src/Test/Integration/Scenario/API/Byron/Wallets.hs:187:59: 
  1) API Specifications, BYRON_WALLETS, BYRON_RESTORE_01, GET_01, LIST_01 - Restore a wallet, ledger 18 words
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiByronWallet {id = ApiT {getApiT = WalletId {getWalletId = 905a2d7a58a9c0450a59fe694e7256b1657038a2}}, balance = ApiByronWalletBalance {available = Quantity {getQuantity = 0}, total = Quantity {getQuantity = 0}}, assets = ApiWalletAssetsBalance {available = ApiT {getApiT = TokenMap (fromList [])}, total = ApiT {getApiT = TokenMap (fromList [])}}, discovery = DiscoverySequential, name = ApiT {getApiT = WalletName {getWalletName = "Empty Byron Wallet"}}, passphrase = Just (ApiWalletPassphraseInfo {lastUpdatedAt = 2021-04-23 12:55:27.284521672 UTC}), state = ApiT {getApiT = Syncing (Quantity {getQuantity = Percentage {getPercentage = 287 % 625}})}, tip = ApiBlockReference {absoluteSlotNumber = ApiT {getApiT = SlotNo 1966}, slotId = ApiSlotId {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 39}}, slotNumber = ApiT {getApiT = SlotInEpoch {unSlotInEpoch = 16}}}, time = 2021-04-23 12:47:45.2 UTC, block = ApiBlockInfo {height = Quantity {getQuantity = 1000}}}}))
       Waited longer than 90s to resolve action: "wallet is available and ready".
       expected: Ready
        but got: Syncing (Quantity {getQuantity = Percentage {getPercentage = 287 % 625}})

  To rerun use: --match "/API Specifications/BYRON_WALLETS/BYRON_RESTORE_01, GET_01, LIST_01 - Restore a wallet/ledger 18 words/"

Randomized with seed 644555522

#2565

piotr-iohk · 2021-04-23T13:35:22Z

bors r+

iohk-bors · 2021-04-23T14:32:29Z

Build succeeded:

2623: e2e tests: fix docker workflow r=piotr-iohk a=piotr-iohk # Issue Number  # Overview  - [ ] I have added a step for docker workflow to get the latest cardano-wallet bundle before starting tests in order to have cardano-address on the path which is required for recently added e2e shared wallet tests # Comments This was slight omission from #2619. Other workflows already have it by default. Tested here on the docker workflow -> https://github.com/input-output-hk/cardano-wallet/actions/runs/784885875 Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>

2623: e2e tests: fix docker workflow r=rvl a=piotr-iohk # Issue Number  # Overview  - [ ] I have added a step for docker workflow to get the latest cardano-wallet bundle before starting tests in order to have cardano-address on the path which is required for recently added e2e shared wallet tests # Comments This was slight omission from #2619. Other workflows already have it by default. Tested here on the docker workflow -> https://github.com/input-output-hk/cardano-wallet/actions/runs/784885875 Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>

2623: e2e tests: fix docker workflow r=rvl a=piotr-iohk # Issue Number  # Overview  - [ ] I have added a step for docker workflow to get the latest cardano-wallet bundle before starting tests in order to have cardano-address on the path which is required for recently added e2e shared wallet tests # Comments This was slight omission from #2619. Other workflows already have it by default. Tested here on the docker workflow -> https://github.com/input-output-hk/cardano-wallet/actions/runs/784885875 2626: Bump version from 2021-04-08 to 2021-04-28 r=rvl a=rvl Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>

2623: e2e tests: fix docker workflow r=rvl a=piotr-iohk # Issue Number  # Overview  - [ ] I have added a step for docker workflow to get the latest cardano-wallet bundle before starting tests in order to have cardano-address on the path which is required for recently added e2e shared wallet tests # Comments This was slight omission from #2619. Other workflows already have it by default. Tested here on the docker workflow -> https://github.com/input-output-hk/cardano-wallet/actions/runs/784885875 Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>

2623: e2e tests: fix docker workflow r=piotr-iohk a=piotr-iohk # Issue Number  # Overview  - [ ] I have added a step for docker workflow to get the latest cardano-wallet bundle before starting tests in order to have cardano-address on the path which is required for recently added e2e shared wallet tests # Comments This was slight omission from #2619. Other workflows already have it by default. Tested here on the docker workflow -> https://github.com/input-output-hk/cardano-wallet/actions/runs/784885875 Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>

2623: e2e tests: fix docker workflow r=rvl a=piotr-iohk # Issue Number  # Overview  - [ ] I have added a step for docker workflow to get the latest cardano-wallet bundle before starting tests in order to have cardano-address on the path which is required for recently added e2e shared wallet tests # Comments This was slight omission from #2619. Other workflows already have it by default. Tested here on the docker workflow -> https://github.com/input-output-hk/cardano-wallet/actions/runs/784885875 2626: Bump version from 2021-04-08 to 2021-04-28 r=rvl a=rvl Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>

piotr-iohk self-assigned this Apr 21, 2021

rvl reviewed Apr 22, 2021

View reviewed changes

piotr-iohk force-pushed the piotr/shared_wallets_testing branch from c4f239a to 9d60455 Compare April 22, 2021 11:13

piotr-iohk requested a review from paweljakubas April 23, 2021 05:58

Piotr Stachyra and others added 10 commits April 23, 2021 11:09

additional e2e tests for shared wallets

b1446a6

fix cardano_addresses cmd on win

47ea685

mark shared wallet endpoints as experimental in swagger

d46bcd3

swagger: Shared wallets status: under development

7ec4600

Add $TESTS_E2E_BINDIR to $PATH

6c89643

remove 'installation' parmeter from rake tasks and use only $TESTS_E2…

20e5178

…E_BINDIR to point to executables to test

pessimistic versioning for cardano_wallet gem

67b9633

fix bin path when starting node and wallet. We're now adding BINS to …

9e3ce5e

…the PATH but absolute path is still needed when starting node and wallet as services on Win.

Use ruby dict as script templates in tests instead of parsing from st…

7bde969

…rings

Clear node cache in e2e jobs. After upgrade to 1.26.2 node is replayi…

b958f40

…ng all the blocks for several minutes so wallet is not able to connect within 180s timeout. The only way to clear GH cache is to change key.

piotr-iohk force-pushed the piotr/shared_wallets_testing branch from 9d60455 to b958f40 Compare April 23, 2021 09:14

paweljakubas reviewed Apr 23, 2021

View reviewed changes

paweljakubas approved these changes Apr 23, 2021

View reviewed changes

iohk-bors bot merged commit 1ab90cd into master Apr 23, 2021

iohk-bors bot deleted the piotr/shared_wallets_testing branch April 23, 2021 14:32

piotr-iohk mentioned this pull request Apr 26, 2021

e2e tests: fix docker workflow #2623

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shared wallets testing #2619

Shared wallets testing #2619

piotr-iohk commented Apr 21, 2021

rvl left a comment

rvl Apr 22, 2021

rvl Apr 22, 2021

piotr-iohk Apr 22, 2021

rvl Apr 22, 2021

piotr-iohk Apr 22, 2021

rvl Apr 22, 2021

rvl Apr 22, 2021

piotr-iohk Apr 22, 2021

rvl Apr 22, 2021

paweljakubas Apr 23, 2021

piotr-iohk Apr 23, 2021

paweljakubas left a comment

piotr-iohk commented Apr 23, 2021

iohk-bors bot commented Apr 23, 2021 •

edited by Anviking

piotr-iohk commented Apr 23, 2021

iohk-bors bot commented Apr 23, 2021 •

edited by Anviking

piotr-iohk commented Apr 23, 2021

iohk-bors bot commented Apr 23, 2021

		pscript = JSON.parse(script_template)
		dscript = JSON.parse(script_template)

Shared wallets testing #2619

Shared wallets testing #2619

Conversation

piotr-iohk commented Apr 21, 2021

Issue Number

Overview

Comments

rvl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paweljakubas left a comment

Choose a reason for hiding this comment

piotr-iohk commented Apr 23, 2021

iohk-bors bot commented Apr 23, 2021 • edited by Anviking

piotr-iohk commented Apr 23, 2021

iohk-bors bot commented Apr 23, 2021 • edited by Anviking

piotr-iohk commented Apr 23, 2021

iohk-bors bot commented Apr 23, 2021

iohk-bors bot commented Apr 23, 2021 •

edited by Anviking

iohk-bors bot commented Apr 23, 2021 •

edited by Anviking