Shared addresses testing #2660
Merged
Shared addresses testing #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paweljakubas
approved these changes
May 19, 2021
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 19, 2021
2660: Shared addresses testing r=piotr-iohk a=piotr-iohk # Issue Number ADP-686 # Overview - dff0102 update cardano_wallet gem - b339aee Add list wallets checks - 71391d8 reword pending as incomplete in e2e tests - 32b7b79 Add tests for list addresses on shared wallets - efc0059 Refactor SharedWallets integration tests into Shared/Wallets.hs and Shared/Addresses.hs # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
|
Build failed: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 20, 2021
2660: Shared addresses testing r=piotr-iohk a=piotr-iohk # Issue Number ADP-686 # Overview - dff0102 update cardano_wallet gem - b339aee Add list wallets checks - 71391d8 reword pending as incomplete in e2e tests - 32b7b79 Add tests for list addresses on shared wallets - efc0059 Refactor SharedWallets integration tests into Shared/Wallets.hs and Shared/Addresses.hs # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
|
Build failed: |
piotr-iohk
force-pushed
the
piotr/shared-addresses-testing
branch
from
efc0059
to
8b81116
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 20, 2021
2660: Shared addresses testing r=piotr-iohk a=piotr-iohk # Issue Number ADP-686 # Overview - dff0102 update cardano_wallet gem - b339aee Add list wallets checks - 71391d8 reword pending as incomplete in e2e tests - 32b7b79 Add tests for list addresses on shared wallets - efc0059 Refactor SharedWallets integration tests into Shared/Wallets.hs and Shared/Addresses.hs # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
|
Build failed: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 20, 2021
2660: Shared addresses testing r=piotr-iohk a=piotr-iohk # Issue Number ADP-686 # Overview - dff0102 update cardano_wallet gem - b339aee Add list wallets checks - 71391d8 reword pending as incomplete in e2e tests - 32b7b79 Add tests for list addresses on shared wallets - efc0059 Refactor SharedWallets integration tests into Shared/Wallets.hs and Shared/Addresses.hs # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
|
Build failed: |
added 2 commits
May 20, 2021 12:16
piotr-iohk
force-pushed
the
piotr/shared-addresses-testing
branch
from
6882f85
to
cf1b080
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-686
Overview
dff0102
update cardano_wallet gem
b339aee
Add list wallets checks
71391d8
reword pending as incomplete in e2e tests
32b7b79
Add tests for list addresses on shared wallets
efc0059
Refactor SharedWallets integration tests into Shared/Wallets.hs and Shared/Addresses.hs
Comments