Fix slow ApiSharedWallet unit tests #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generators were doing crypto operations - which are really slow and generally not required for test cases.
It was ignoring the scale parameter and therefore generating excessively long names.
jonathanknowles
approved these changes
May 24, 2021
| nameLength <- choose (walletNameMinLength, walletNameMaxLength) | ||
| WalletName . T.pack <$> replicateM nameLength arbitraryPrintableChar | ||
| len <- Test.QuickCheck.scale (min walletNameMaxLength) $ sized $ \n -> | ||
| chooseInt (walletNameMinLength, walletNameMinLength `max` n) |
| genMockXPub = fromMaybe impossible . xpubFromBytes . BS.pack <$> genBytes | ||
| where | ||
| genBytes = vectorOf 64 arbitrary | ||
| impossible = error "incorrect length in genMockXPub" |
There was a problem hiding this comment.
yeah, we can generate here random bytes 💯
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 24, 2021
2664: Fix slow ApiSharedWallet unit tests r=paweljakubas a=rvl ### Issue Number Found during ADP-902 ### Overview The `Cardano.Wallet.Api.Types` tests are running very slowly. Also the unit tests were sometimes timing out in CI. Profiling showed that the `Arbitrary` instance of `ApiSharedWallet` was the slowest part. This change improves the speed of this generator. Now it is the OpenAPI validation which is the slowest part. ### Comments We may also be able to reduce the size of arbitrary `ApiSharedWallet` values, so that validation gets faster. Because it's still not especially quick. Something like the `instance Arbitrary WalletName` change in this PR could probably be applied. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Found during ADP-902
Overview
The
Cardano.Wallet.Api.Typestests are running very slowly. Also the unit tests were sometimes timing out in CI.Profiling showed that the
Arbitraryinstance ofApiSharedWalletwas the slowest part.This change improves the speed of this generator.
Now it is the OpenAPI validation which is the slowest part.
Comments
We may also be able to reduce the size of arbitrary
ApiSharedWalletvalues, so that validation gets faster. Because it's still not especially quick. Something like theinstance Arbitrary WalletNamechange in this PR could probably be applied.