Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v2021-05-26 #2669

Merged
merged 4 commits into from
May 26, 2021
Merged

Bump version to v2021-05-26 #2669

merged 4 commits into from
May 26, 2021

Conversation

rvl
Copy link
Contributor

@rvl rvl commented May 26, 2021

Overview

As per the Release Checklist.

@rvl rvl self-assigned this May 26, 2021
@rvl
Copy link
Contributor Author

rvl commented May 26, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request May 26, 2021
2669: Bump version to v2021-05-26 r=rvl a=rvl

### Overview

As per the [Release Checklist](https://github.com/input-output-hk/cardano-wallet/wiki/Release-Checklist).


Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 26, 2021

Build failed:

@rvl
Copy link
Contributor Author

rvl commented May 26, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request May 26, 2021
2662: Basic migration plans e2e tests r=rvl a=piotr-iohk

# Issue Number

ADP-680


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] e2e tests on testnet for creating migration plans for Byron/Icarus/Shelley wallets.


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


2669: Bump version to v2021-05-26 r=rvl a=rvl

### Overview

As per the [Release Checklist](https://github.com/input-output-hk/cardano-wallet/wiki/Release-Checklist).


2671: swagger: Add decimals field r=rvl a=rvl

### Issue Number

ADP-915

### Overview

Updates the swagger documentation to replace `unit` with `decimals`.



Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 26, 2021

Build failed (retrying...):

iohk-bors bot added a commit that referenced this pull request May 26, 2021
2669: Bump version to v2021-05-26 r=rvl a=rvl

### Overview

As per the [Release Checklist](https://github.com/input-output-hk/cardano-wallet/wiki/Release-Checklist).


Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 26, 2021

Build failed:

@Anviking
Copy link
Collaborator

bors r+

iohk-bors bot added a commit that referenced this pull request May 26, 2021
2662: Basic migration plans e2e tests r=rvl a=piotr-iohk

# Issue Number

ADP-680


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] e2e tests on testnet for creating migration plans for Byron/Icarus/Shelley wallets.


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


2669: Bump version to v2021-05-26 r=Anviking a=rvl

### Overview

As per the [Release Checklist](https://github.com/input-output-hk/cardano-wallet/wiki/Release-Checklist).


2670: API: Pass TokenMetadataError through to API r=Anviking a=rvl

### Issue Number

ADP-925

### Overview

If there was an error fetching metadata in the listMetadata or getMetadata endpoints, tell the user, rather than just returning "no metadata".

### Comments

Could someone please pick this up and merge for v2021-05-26.


2673: Testing additional account pub key endpoints r=piotr-iohk a=piotr-iohk

# Issue Number

ADP-934


# Overview

- 55b2fa4
  Tests for get acc pub key for shelley and shared wallets
  
- a388e30
  Add assertions for shared wallet status
  
- 9ab8eaf
  Cannot create acc pub key for wallets from acc pub key tests
  
- 42dab09
  Re-shuffle order and extend summary of key eps in swagger for clarity


# Comments

I've also improved a bit key endpoints summary in swagger for better clarity:

![Screenshot from 2021-05-26 16-08-47](https://user-images.githubusercontent.com/42900201/119674720-b80b5e00-be3c-11eb-81e5-38d95f88131f.png)

![Screenshot from 2021-05-26 16-09-01](https://user-images.githubusercontent.com/42900201/119674734-bcd01200-be3c-11eb-824e-c104bf1b927b.png)



Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 26, 2021

Build failed (retrying...):

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 26, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit f43bc23 into master May 26, 2021
@iohk-bors iohk-bors bot deleted the rvl/bump-release/2021-05-26 branch May 26, 2021 18:16
WilliamKingNoel-Bot pushed a commit that referenced this pull request May 26, 2021
2669: Bump version to v2021-05-26 r=Anviking a=rvl

### Overview

As per the [Release Checklist](https://github.com/input-output-hk/cardano-wallet/wiki/Release-Checklist).

2673: Testing additional account pub key endpoints r=piotr-iohk a=piotr-iohk

# Issue Number

ADP-934

# Overview

- 55b2fa4
  Tests for get acc pub key for shelley and shared wallets

- a388e30
  Add assertions for shared wallet status

- 9ab8eaf
  Cannot create acc pub key for wallets from acc pub key tests

- 42dab09
  Re-shuffle order and extend summary of key eps in swagger for clarity

# Comments

I've also improved a bit key endpoints summary in swagger for better clarity:

![Screenshot from 2021-05-26 16-08-47](https://user-images.githubusercontent.com/42900201/119674720-b80b5e00-be3c-11eb-81e5-38d95f88131f.png)

![Screenshot from 2021-05-26 16-09-01](https://user-images.githubusercontent.com/42900201/119674734-bcd01200-be3c-11eb-824e-c104bf1b927b.png)

Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io> f43bc23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants