Add functions for serializing keys as text #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
reviewed
May 16, 2019
paweljakubas
force-pushed
the
rvl/143/serialize-keys
branch
3 times, most recently
from
546945d
to
a88694b
Compare
To store XPrv and XPub in a database column or text file, a hex-encoded string is best.
KtorZ
approved these changes
May 16, 2019
| -> Property | ||
| prop_roundtripXPriv xpriv = do | ||
| let (Right xpriv') = (deserializeXPrv . serializeXPrv) xpriv | ||
| xpriv === xpriv' |
There was a problem hiding this comment.
This should rather be written:
xpriv' = (deserializeXPrv . serializeXPrv) xpriv
Right xpriv === xpriv'With the latter version, in case the property fails, we get a nice error output with a counter example from Quickcheck. With the former, it blows up because of an invalid pattern-match 😬
| genRootKeys :: Gen (Key 'RootK XPrv) | ||
| genRootKeys = do | ||
| (s, g, e) <- (,,) | ||
| <$> genPassphrase @"seed" (0, 32) |
There was a problem hiding this comment.
Minor remark but the seed should be at least 16-bit according to cardano-crypto:
-- | Generate a new XPrv from an entropy seed
--
-- The seed should be at least 16 bytes, although it is not enforced
--
-- The passphrase encrypt the secret key in memory
generateNew :: (ByteArrayAccess keyPassPhrase, ByteArrayAccess generationPassPhrase, ByteArrayAccess seed)We don't actually have any comment on the matter in our code either. I'll put a point on the blackboard.
paweljakubas
force-pushed
the
rvl/143/serialize-keys
branch
from
a88694b
to
e224d4b
Compare
address review remarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #143.
Overview
To store XPrv and XPub in a database column or text file, a hex-encoded string is suitable.