Implement Jörmungandr Transaction-message decoder #273
Conversation
Anviking
force-pushed
the
anviking/218/jörmungandr-tx
branch
from
64e46d6
to
23213e1
Compare
|
|
||
| 2 -> isolate 64 $ do | ||
| _sig <- Hash <$> getByteString 64 | ||
| error "unimplemented: New address witness scheme" |
There was a problem hiding this comment.
Trying to implement as little as possible for now…
Anviking
force-pushed
the
anviking/218/jörmungandr-tx
branch
2 times, most recently
from
17b6622
to
8b4dfec
Compare
Anviking
force-pushed
the
anviking/218/jörmungandr-tx
branch
from
8b4dfec
to
58dfa56
Compare
| @@ -70,8 +80,9 @@ data TODO = TODO | |||
| data SignedVote = SignedVote | |||
| deriving (Eq, Show) | |||
|
|
|||
| -- Do-notation is favoured over applicative syntax for readability: | |||
| {-# ANN module ("HLint: ignore Use <$>" :: String) #-} | |||
| , outputs = | ||
| [ TxOut | ||
| { address = Address "3$\195xi\193\"h\154\&5\145}\245:O\"\148\163\165/h^\ENQ\245\248\229;\135\231\234E/" | ||
| , coin = Coin 14 |
There was a problem hiding this comment.
Coin 14 sounds like something I've could have put in the genesis block indeed 😂
|
|
||
| getTokenTransfer :: Get ([TxIn], [TxOut]) | ||
| getTokenTransfer = do | ||
| inCount <- fromIntegral <$> getWord8 |
There was a problem hiding this comment.
don't we miss transaction header (2bytes) here according to https://github.com/input-output-hk/rust-cardano/blob/master/chain-impl-mockchain/doc/format.md#token-transfer
There was a problem hiding this comment.
It works this way 🤷♂ (+ I guess I followed the rust-decoder)
| let _discrimination = discriminationValue headerByte | ||
| case kind of | ||
| -- Single Address | ||
| 0x3 -> Address <$> getByteString 32 |
There was a problem hiding this comment.
where can I find this info? I can't seem to find it in https://github.com/input-output-hk/rust-cardano/blob/master/chain-impl-mockchain/doc/format.md#preliminaries
There was a problem hiding this comment.
Issue Number
#218
Overview
TransactionmessageComments
DiscriminationwithNetwork