Docs, polish and config param 16 #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
force-pushed
the
anviking/218/polish
branch
from
17fdaeb
to
bb779e4
Compare
KtorZ
force-pushed
the
anviking/218/polish
branch
from
bb779e4
to
fec27f0
Compare
KtorZ
approved these changes
May 17, 2019
KtorZ
reviewed
May 17, 2019
| @@ -282,11 +301,20 @@ newtype LeaderId = LeaderId ByteString | |||
| data LinearFee = LinearFee Word64 Word64 Word64 | |||
| deriving (Eq, Show) | |||
|
|
|||
| data ConsensusVersion = BFT | GenesisPraos | |||
| deriving (Eq, Show) | |||
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 17, 2019
274: Implement ability to list addresses in the wallet layer, API and CLI r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #220 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [ ] I have implemented the ability to list addresses in the wallet layer, API and CLI # Comments <!-- Additional comments or screenshots to attach if any --> This would make it easier for @piotr-iohk and us to write some integration tests for the transaction API. We could have derived addresses by hand, but this achieves to complete the high-priority endpoints of the API. NOTE: It's a "partial" implementation which for now, ignores the filtering based on the address state (`?state=used` or `?state=unused`). This can be implemented later. :warning: I recommend looking at the change commit by commit ;) <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> 275: Docs, polish and config param 16 r=KtorZ a=Anviking # Issue Number #218 # Overview - [x] Appropriated some doc comments from the [list of config params](https://github.com/input-output-hk/rust-cardano/blob/master/chain-impl-mockchain/doc/format.md) - [x] Added missing `KesUpdateSpeed ` parameter - [x] Added `ConsensusVersion` data-type - [x] Some other super-minor polish # Comments <!-- Additional comments or screenshots to attach if any -->⚠️ the base is temporarily not `master`⚠️ <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
Timed out (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
May 17, 2019
275: Docs, polish and config param 16 r=KtorZ a=Anviking # Issue Number #218 # Overview - [x] Appropriated some doc comments from the [list of config params](https://github.com/input-output-hk/rust-cardano/blob/master/chain-impl-mockchain/doc/format.md) - [x] Added missing `KesUpdateSpeed ` parameter - [x] Added `ConsensusVersion` data-type - [x] Some other super-minor polish # Comments <!-- Additional comments or screenshots to attach if any -->⚠️ the base is temporarily not `master`⚠️ <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
Timed out |
Anviking
force-pushed
the
anviking/218/polish
branch
2 times, most recently
from
510ba8e
to
a736a27
Compare
- use Data.Quantity for LinearFee and config params - Polish comments and error message
Anviking
force-pushed
the
anviking/218/polish
branch
from
a736a27
to
651dd8b
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 17, 2019
275: Docs, polish and config param 16 r=Anviking a=Anviking # Issue Number #218 # Overview - [x] Appropriated some doc comments from the [list of config params](https://github.com/input-output-hk/rust-cardano/blob/master/chain-impl-mockchain/doc/format.md) - [x] Added missing `KesUpdateSpeed ` parameter - [x] Added `ConsensusVersion` data-type - [x] Some other super-minor polish # Comments <!-- Additional comments or screenshots to attach if any -->⚠️ the base is temporarily not `master`⚠️ <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
Timed out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#218
Overview
KesUpdateSpeedparameterConsensusVersiondata-typeComments
master