Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some small fixes to DB.StateMachine module. #349

Merged
merged 9 commits into from
Jun 4, 2019
Merged

Some small fixes to DB.StateMachine module. #349

merged 9 commits into from
Jun 4, 2019

Commits on Jun 4, 2019

  1. Use plural name for map of private keys within Mock data type. 

    The `Mock` data type has the convention that each map has a plural name
based on the type of value held within the map. For consistency with
this convention, the map of wallet ids to private keys should also have
a plural name.

Similarly, we can use `pks` to represent a map, but `pk` to represent a
value within a map.
    @jonathanknowles
    jonathanknowles committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    da73f8b View commit details
    Browse the repository at this point in the history

  2. Avoid repetition by moving application of fmap At.

    @jonathanknowles
    jonathanknowles committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    34a4965 View commit details
    Browse the repository at this point in the history

  3. Use standard indentation (4 spaces).

    @jonathanknowles
    jonathanknowles committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    8beb8a4 View commit details
    Browse the repository at this point in the history

  4. Wrap code to standard 80 characters.

    @jonathanknowles
    jonathanknowles committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    48afdb5 View commit details
    Browse the repository at this point in the history

  5. Fix bug where the incorrect tag was returned from createThreeWallets. 

    It previously returned `CreateWalletTwice`, but it should return
`CreateThreeWallets`.
    @jonathanknowles
    jonathanknowles committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    48131de View commit details
    Browse the repository at this point in the history

  6. Inline arguments to function readAfterDelete. 

    This function is always called with the same arguments, so we can safely
inline these arguments.
    @jonathanknowles
    jonathanknowles committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    071c320 View commit details
    Browse the repository at this point in the history

  7. Add missing space.

    @jonathanknowles
    jonathanknowles committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    5c84d1e View commit details
    Browse the repository at this point in the history

  8. Fix typo and add full stops to Haddock comments.

    @jonathanknowles
    jonathanknowles committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    901edf5 View commit details
    Browse the repository at this point in the history

  9. Delete obsolete comment.

    @jonathanknowles
    jonathanknowles committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    8048d37 View commit details
    Browse the repository at this point in the history