Add initial support for serializing signed transaction #362
Conversation
| putWord8 1 | ||
| putByteString xPub | ||
| putByteString sig | ||
| -- TODO: note that we are missing new address type witness: |
There was a problem hiding this comment.
we still didn't cover acount and new address witness scheme
There was a problem hiding this comment.
Got you, though I am bit sad to see that we only merge this while the whole story was expected to be completed already 8 days ago.
| -- * https://github.com/input-output-hk/rust-cardano/blob/3524cfe138a10773caa6f0effacf69e792f915df/chain-impl-mockchain/doc/format.md#witnesses | ||
| -- * https://github.com/input-output-hk/rust-cardano/blob/e0616f13bebd6b908320bddb1c1502dea0d3305a/chain-impl-mockchain/src/transaction/witness.rs#L23 | ||
| ScriptWitness _ -> error "unimplemented: serialize script witness" | ||
| RedeemWitness _ -> error "unimplemented: serialize redeem witness" |
There was a problem hiding this comment.
I am not sure atm how rust node covers these two cases. Maybe they are encoded under old or normal utxo witness scheme
| where | ||
| putInput (TxIn inputId inputIx) = do | ||
| -- NOTE: special value 0xff indicates account spending | ||
| -- only old utxo/address scheme supported for now |
There was a problem hiding this comment.
I have to recall what is new address scheme. I am not sure how to correctly map what we said here https://github.com/input-output-hk/cardano-wallet/blob/master/lib/core/src/Cardano/Wallet/Primitive/Types.hs#L481 with jow rust node encode operates https://github.com/input-output-hk/rust-cardano/blob/3524cfe138a10773caa6f0effacf69e792f915df/chain-impl-mockchain/doc/format.md#token-transfer
Address (bootstrap address 33 bytes, delegation address 65 bytes, account address 33 bytes)
| putAddress address | ||
| putWord64be $ getCoin coin | ||
| putAddress address = do | ||
| -- NOTE: only single address supported for now |
There was a problem hiding this comment.
I think that we actually have support for other kinds of addresses (old/new/grouped) https://github.com/input-output-hk/cardano-wallet/blob/master/lib/core/src/Cardano/Wallet/Primitive/Types.hs#L481 - so we should be able to implement this I think
|
Nice, will have a look later. Would it be possible/relevant to generate some golden test cases with |
yes - that's my plan for the rest of the day today |
|
@akegalj any updates on that one ? |
I am playing with |
| :> ReqBody '[JormungandrBinary] SignedTx | ||
| :> Post '[NoContent] NoContent | ||
|
|
||
| -- TODO: Replace SignedTx with something real | ||
| data SignedTx | ||
| type SignedTx = (Tx, [TxWitness]) |
There was a problem hiding this comment.
Let's remove this and use ReqBody '[JormungandrBinary] (Tx, [TxWitness]) directly then
| @@ -230,6 +272,7 @@ getTokenTransfer = do | |||
| let _discrimination = discriminationValue headerByte | |||
| case kind of | |||
| -- Single Address | |||
| -- TODO(akegalj) shouldn't this be `either fail id . decodeAddress (Proxy Jormungandr) <$> getByteString 32` ? | |||
There was a problem hiding this comment.
yes - removed - forgot to push
| -- NOTE: only single address supported for now | ||
| putWord8 single | ||
| -- TODO(akegalj) this should be `encodeAddress (Proxy Jormungandr) address` | ||
| putByteString "addressBytestring" -- address |
There was a problem hiding this comment.
So we're essentially just missing a putByteString of the unwrapped bytes here, and it "should work"?
There was a problem hiding this comment.
yes - forgot to push that commit - will push in a sec
akegalj
force-pushed
the
akegalj/219/serialize_tx
branch
from
e28018d
to
b7a1e14
Compare
akegalj
force-pushed
the
akegalj/219/serialize_tx
branch
from
b7a1e14
to
ff9e902
Compare
Issue Number
#219
Overview
Comments