cli: Use Paths module to get program version

[rvl]

The CLIs build normally, but embedFile wasn't working for me in ghci.

  lib/cli/src/Cardano/CLI.hs:275:27: error:
      • Exception when trying to run compile-time code:
          ../../cardano-wallet.cabal: openBinaryFile: does not exist (No such file or directory)
        Code: embedFile "../../cardano-wallet.cabal"
      • In the untyped splice: $(embedFile "../../cardano-wallet.cabal")
      |
  275 |     let cabal = B8.unpack $(embedFile "../../cardano-wallet.cabal")
      |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

There is another easier way to get the program version (assuming all cabal files have the same version).

[jonathanknowles]

I guess one alternative to this would be to use makeRelativeToProject.

But I think your solution is nicer, as it removes the parsing logic.

[jonathanknowles]

I tested this out on my system, and the following now works:

$ stack clean
$ stack ghci cardano-wallet-cli:lib

GHCi loads successfully with no errors.

[jonathanknowles]

This looks like a nice solution. It also uses less code than the alternative, which would be to keep the existing parsing logic and use makeRelativeToProject.

I've tested it out on my system, and didn't run into any issues.

[jonathanknowles]

@rvl Looks like you have some redundant build-depends entries:

== Section library ==
Redundant build-depends entry
* bytestring
* file-embed
* regex-applicative

[rvl]

Thanks.

I would avoid embedFile as much as possible. Also makeRelativeToProject. If it's referring to something above the package tree with ../ then it will often cause build problems.

You generally don't need to repeat what Travis finds because GitHub prevents merging a PR that fails CI, and it can easily be found by clicking on the red cross.

[KtorZ]

I've also modified the hard-coded version from the integration test scenario to use this approach instead. Neat 👍