cli: Add "local" network to launcher, and --state-dir for the database #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
| @@ -74,15 +81,17 @@ main = do | |||
| when (args `isPresent` (shortOption 'h')) $ help cli | |||
| when (args `isPresent` (longOption "version")) $ putStrLn getVersion | |||
|
|
|||
| network <- args `parseArg` longOption "network" | |||
| let stateDir = args `getArg` (longOption "state-dir") | |||
| let network = fromMaybe "testnet" $ args `getArg` (longOption "network") | |||
There was a problem hiding this comment.
Just a small point, but parentheses are not actually needed in the above two lines.
piotr-iohk
reviewed
Jun 6, 2019
| @@ -62,9 +68,10 @@ Usage: | |||
| cardano-wallet-launcher --version | |||
|
|
|||
| Options: | |||
| --network <STRING> testnet, staging, or mainnet [default: testnet] | |||
| --network <STRING> testnet, staging, mainnet, or local [default: testnet] | |||
There was a problem hiding this comment.
why is local coming back?
There was a problem hiding this comment.
Because of Daedalus integrating with the wallet backend. They also need to be able to spin-up a local cluster for their own testing.
piotr-iohk
reviewed
Jun 6, 2019
| @@ -74,15 +81,17 @@ main = do | |||
| when (args `isPresent` (shortOption 'h')) $ help cli | |||
| when (args `isPresent` (longOption "version")) $ putStrLn getVersion | |||
|
|
|||
| network <- args `parseArg` longOption "network" | |||
| let stateDir = args `getArg` (longOption "state-dir") | |||
There was a problem hiding this comment.
It would be nice to add integration test that'd check if the directory and contents are created correctly.
Could be here -> https://github.com/input-output-hk/cardano-wallet/tree/master/lib/http-bridge/test/integration/Test/Integration/Scenario/CLI
KtorZ
force-pushed
the
rvl/launcher-fix
branch
2 times, most recently
from
a0a7a61
to
264a459
Compare
Changes the DBLayer to use SQLite. Without a given filename, it just uses the in-memory database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue #154
This branch is based on the branch of #377
Overview
--state-dir. That can also control wherecardano-http-bridgeputs its files.cardano-http-bridgefork supports--template local, butcardano-wallet-launcherwouldn't recognise that as a valid network.