review & fix jormungandr configuration to enable block production in BFT mode #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
commented
Jun 6, 2019
| @@ -22,19 +22,19 @@ blockchain_configuration: | |||
| block0_consensus: bft | |||
|
|
|||
| # Number of slots in each epoch | |||
| slots_per_epoch: 2160 | |||
| slots_per_epoch: 500 | |||
There was a problem hiding this comment.
Just to avoid too many blocks in the schedule which makes the logger panics otherwise 🤷♂️ ... And, it'll be fun to not use 2160 slots per epoch, I am sure of it.
KtorZ
commented
Jun 6, 2019
|
|
||
| # The number of blocks (*10) per epoch | ||
| epoch_stability_depth: 10 | ||
|
|
||
| # A list of Ed25519 Extended PublicKey that represents the | ||
| # BFT leaders encoded as bech32. The order in the list matters. | ||
| consensus_leader_ids: | ||
| - ed25519e_pk1xznffwqdhw3drw9yk4t99vpajcc4epq5kp205um5gkkz625xt3mqn4z3mx | ||
| - ed25519_pk1kgtwuwy0cf2edn6rl09gzhzx8sma09tqhxzcqrpaduaq7k5h0ceqe4qqpv |
There was a problem hiding this comment.
So, this was the main reason blocks weren't produce. The leader defined in the genesis file was not the one pointed by the node configuration...
KtorZ
commented
Jun 6, 2019
| @@ -21,7 +21,7 @@ spec = describe "cardano-wallet-launcher" $ do | |||
| let jormungandrLauncher = Command | |||
| "jormungandr" | |||
| [ "--genesis-block", dir ++ "/block-0.bin" | |||
| , "--config", dir ++ "/node.config" | |||
| , "--config", dir ++ "/config.yaml" | |||
There was a problem hiding this comment.
using .yaml since this is actually a yaml file...
Anviking
force-pushed
the
KtorZ/jormungandr-produces-blocks
branch
from
b4aa361
to
290a18e
Compare
1 task
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#219
Overview
Comments
Not sure how the leader ids were generated in the genesis file but, it didn't match the public key of the signing key given as configuration. Now fixed and Jormungandr correctly produces block in BFT mode now.
Note that because the node is alone, it schedules a lot of blocks which result in quite a lot of messages (and eventually error messages from the logger which can't keep up). I've alerted the rust team and they're looking into it.