Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3054] test migration backup #3993

Merged
merged 1 commit into from
Jun 16, 2023
Merged

[ADP-3054] test migration backup #3993

merged 1 commit into from
Jun 16, 2023

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jun 15, 2023 •
edited
Loading

A small addition to this task to prove that DB backup and DB access work well on all platforms.

ADP-3054

@paolino paolino changed the base branch from master to paolino/ADP-3054/integrate-new-delegation-certificate-store June 15, 2023 13:23
@paolino paolino marked this pull request as ready for review June 15, 2023 13:23
@paolino paolino self-assigned this Jun 15, 2023
HeinrichApfelmus
HeinrichApfelmus approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😊 🙏 Suggesting a newline.

lib/wallet/test/unit/Cardano/Wallet/DB/Sqlite/Migration/NewSpec.hs Show resolved Hide resolved
Base automatically changed from paolino/ADP-3054/integrate-new-delegation-certificate-store to master June 15, 2023 13:52
@paolino paolino force-pushed the paolino/ADP-3054/test-migration-backup branch from 97802f3 to 4858c05 Compare June 16, 2023 08:46
@paolino
Copy link
Collaborator Author

paolino commented Jun 16, 2023

bors r+

iohk-bors bot added a commit that referenced this pull request Jun 16, 2023
@iohk-bors @paolino
Merge #3993
d75e0cb 
3993: [ADP-3054] test migration backup r=paolino a=paolino

A small addition to this task to prove that DB backup and DB access work well on all platforms.

ADP-3054

Co-authored-by: paolino <paolo.veronelli@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 16, 2023

Build failed:

@paolino
Copy link
Collaborator Author

paolino commented Jun 16, 2023

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 16, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit ba1f811 into master Jun 16, 2023
2 checks passed
@iohk-bors iohk-bors bot deleted the paolino/ADP-3054/test-migration-backup branch June 16, 2023 15:32
WilliamKingNoel-Bot pushed a commit that referenced this pull request Jun 16, 2023
docs: Merge #3993 3993: [ADP-3054] test migration backup r=paolino a=…
08d17f7 
…paolino A small addition to this task to prove that DB backup and DB access work well on all platforms. ADP-3054 Co-authored-by: paolino <paolo.veronelli@gmail.com> Source commit: ba1f811
@paolino
Copy link
Collaborator Author

paolino commented Jun 16, 2023

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 16, 2023

Already running a review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paolino @HeinrichApfelmus