Add goldens for singleAddressFromKey #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
commented
Jun 18, 2019
| -- ^ corresponding testnet address ("ta...") | ||
| -> Text | ||
| -- ^ corresponding mainnet address ("ca...") | ||
| -> Spec |
There was a problem hiding this comment.
Reasoning for using Text -> Text -> Text:
- The human readable parts of the bech32 strings already act as types (just not at compile-time)
- Allows for easy copy-and-paste at call-site for comparison with
jcli
Anviking
commented
Jun 18, 2019
| bech32KeyToAddrGolden | ||
| "ed25519_pk1yv0er3wlzvcauqj470tesdlcwy4dll9w7cvsvn4q30678gh44tnsxdh75c" | ||
| "ta1sv33lyw9mufnrhsz2hea0xphlpcj4hlu4mmpjpjw5z9ltcaz7k4wwywkd6j" | ||
| "ca1qv33lyw9mufnrhsz2hea0xphlpcj4hlu4mmpjpjw5z9ltcaz7k4ww0xfchg" |
There was a problem hiding this comment.
A caveat is that it is unreadable if you don't know of the meaning of the human readable parts.
A benefit from passing in Text directly is that bech32KeyToAddrGolden has more control, and can output the key in bech32 format despite there being no encodeBech32Key.
Maybe we should add encode/decodeBech32Key in AddressDerivation… 🤔
There was a problem hiding this comment.
To make things more readable without impeding too much on the flexibility, you may use a record type and use record fields at the call-site 👍
Comparing with jcli
Anviking
force-pushed
the
anviking/219/keyToAddr-goldens
branch
from
da9e6b0
to
4982784
Compare
KtorZ
reviewed
Jun 18, 2019
| else error $ "failed to decode key: " ++ hrp ++ " is not ed25519_pk" | ||
|
|
||
| cc :: ChainCode | ||
| cc = ChainCode "<ChainCode shouldn't be used by keyToAddress>" |
There was a problem hiding this comment.
Note that these looks quite redundant with:
Or am I missing something 🤔 ?
1 task
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#219
Overview
bech32KeyToAddrGoldenhelper and three goldens testingsingleAddressFromKeyComments
jcli.keyToAddress. This would have required constructing aKey 'AddressK XPubfrom bech32, which is inconvenient. I have therefore opted to only testsingleAddressFromKey.An alternative approach I originally went with but abandoned was to generate the keys properly from mnemonics instead of decoding them from bech32.