[ADP-106] Support restoration-from option in create-wallet API #4382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolino
force-pushed
the
paolino/ADP-106/change-create-wallet-API-to-support-restoration-date
branch
3 times, most recently
from
2a3e154
to
0f00242
Compare
paweljakubas
reviewed
Jan 3, 2024
paweljakubas
reviewed
Jan 3, 2024
paweljakubas
reviewed
Jan 3, 2024
paweljakubas
reviewed
Jan 3, 2024
lib/wallet/api/http/Cardano/Wallet/Api/Types/RestorationMode.hs
Outdated
Show resolved
Hide resolved
paweljakubas
requested changes
Jan 3, 2024
There was a problem hiding this comment.
Looks nice. It would be good to do three more things in this API-affecting PR:
- add specification in a separate md file like we did for example for one change addr wallet : https://github.com/cardano-foundation/cardano-wallet/blob/master/specifications/api/one-change-address-mode.md
- Make sure shelley and shared wallet are covered
- Please regenerate golden for
PostWalletData. ie. remove the file and then run unit tests like below
CREATE_MISSING_GOLDEN=TRUE cabal run cardano-wallet:test:unit
|
PS. Those files deleted are not part of this PR..Could you exclude them and create separate cleaning PR for this task? |
paolino
force-pushed
the
paolino/ADP-106/change-create-wallet-API-to-support-restoration-date
branch
2 times, most recently
from
f21845a
to
fa66d54
Compare
paolino
added
the
ADDING FEATURE
paolino
force-pushed
the
paolino/ADP-106/change-create-wallet-API-to-support-restoration-date
branch
16 times, most recently
from
da29adc
to
d289531
Compare
Fortunately, we already have an endpoint which does exactly that: https://cardano-foundation.github.io/cardano-wallet/api/edge/#operation/getBlocksLatestHeader It has a more REST-like path. |
paolino
force-pushed
the
paolino/ADP-106/change-create-wallet-API-to-support-restoration-date
branch
2 times, most recently
from
5e27343
to
bbb3fea
Compare
paolino
force-pushed
the
paolino/ADP-106/change-create-wallet-API-to-support-restoration-date
branch
from
bbb3fea
to
b82fdad
Compare
paolino
force-pushed
the
paolino/ADP-106/change-create-wallet-API-to-support-restoration-date
branch
from
b82fdad
to
794b206
Compare
paweljakubas
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
thanks for adopting changes/improvemnts. I played a little with your branch and it looks fine. Please merge CLI branch onto this one before merging. Also I wonder if we could add unit tests and properties showing that
- if we have wallet created after slot1 then for any slot2 < slot1 and slot3 < slot2 the wallet state is the same.
- if we have wallet created after slot1 then for any slot2 < slot1 and fromGenesis we the wallet state the same
- for any wallet created at any point txs for wallet created from genesis include txs for wallet restored from any slot < tip which in turn include txs restored from tip.
etc.etc .(of course could be in separate PR if you find this idea compelling)
Overall LGTM! Great work!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
This PR adds support for restoration from a given chainpoint for shelley wallets. - [x] Add RestorationMode optional field to the API specs - [x] Add RestorationMode and API counterpart haskell type - [x] Add some datatype to transport the mode to the DBLayer (StartRestorationPoint) - [x] Add a datatype to hold the initial state of a wallet (InitialState) - [x] Update JSON golden for WalletPostData - [x] Implement the database support for the mode ADP-106
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
paolino
deleted the
paolino/ADP-106/change-create-wallet-API-to-support-restoration-date
branch
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
…4382) This PR adds support for restoration from a given chainpoint for shelley wallets. - [x] Add RestorationMode optional field to the API specs - [x] Add RestorationMode and API counterpart haskell type - [x] Add some datatype to transport the mode to the DBLayer (StartRestorationPoint) - [x] Add a datatype to hold the initial state of a wallet (InitialState) - [x] Update JSON golden for WalletPostData - [x] Implement the database support for the mode ADP-106 Source commit: 416a7d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for restoration from a given chainpoint for shelley wallets.
ADP-106