add ErrInvalidTx to capture Quantity=0 situation in Byron (http-bridge) #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paweljakubas
force-pushed
the
paweljakubas/364/transaction-with-0-errors
branch
2 times, most recently
from
d797869
to
284e8b2
Compare
paweljakubas
changed the title
KtorZ
reviewed
Jun 20, 2019
| = ErrKeyNotFoundForAddress Address | ||
| -- ^ We tried to sign a transaction with inputs that are unknown to us? | ||
| | ErrInvalidTx | ||
| -- ^ when transaction with 0 amount is tried (not valid in Shelly) |
There was a problem hiding this comment.
Comment is wrong: Shelly --> Byron
There was a problem hiding this comment.
indeed, corrected
KtorZ
reviewed
Jun 20, 2019
| @@ -52,10 +54,12 @@ newTransactionLayer = TransactionLayer | |||
| { mkStdTx = \keyFrom inps outs -> do | |||
| let ins = (fmap fst inps) | |||
| let tx = Tx ins outs | |||
| unless (not (any (\ (TxOut _ c) -> c == Coin 0) outs)) | |||
There was a problem hiding this comment.
when (any ...) is a bit less-confusing than the double-negation "unless (not (any" I think 😄
There was a problem hiding this comment.
yes, I had when (not. null ... which is more natural to me, but hlint suggested current version. I used , when (any ..) in the end
KtorZ
reviewed
Jun 20, 2019
| -- Not working, maybe we need to make TransactionLayer polymorphic | ||
| let txSigData = txId @(HttpBridge n) tx | ||
| txWitnesses <- forM inps $ \(_in, TxOut addr _c) -> mkWitness txSigData | ||
| <$> withEither (ErrKeyNotFoundForAddress addr) (keyFrom addr) | ||
| <$> maybeToRight (ErrKeyNotFoundForAddress addr) (keyFrom addr) |
KtorZ
reviewed
Jun 20, 2019
| @@ -220,6 +221,10 @@ errMsg403NotEnoughMoney has needs = "I can't process this payment because there' | |||
| \ " ++ show has ++ " Lovelace, but I need " ++ show needs ++ " Lovelace\ | |||
| \ (excluding fee amount) in order to proceed with the payment." | |||
|
|
|||
| errMsg403InvalidTransaction :: String | |||
| errMsg403InvalidTransaction = "I can't process this payment because transactions\ | |||
| \ with 0 amount are not supported in Byron." | |||
There was a problem hiding this comment.
Wording suggestion:
I can't process this payment because it contains at least one payment output of value 0. This isn't supported by the current core nodes.
paweljakubas
force-pushed
the
paweljakubas/364/transaction-with-0-errors
branch
from
f31da85
to
a1281c3
Compare
KtorZ
approved these changes
Jun 21, 2019
nix-tools patch add test illustrating the case
correct comment
KtorZ
force-pushed
the
paweljakubas/364/transaction-with-0-errors
branch
from
d96cab2
to
d61a812
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#364
Overview
Comments