Revert to using deprecated Shelley.evaluateTransactionFee call
#4511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the switch made in the recent node bump out of precaution, as the behaviour of `estimateMinFeeTx` is different from that of `evaluateTransactionFee`
Anviking
commented
Mar 27, 2024
| 2.050000,ErrBalanceTxUnableToCreateChange (ErrBalanceTxUnableToCreateChangeError {requiredCost = Coin 170737, shortfall = Coin 120737}) | ||
| 2.100000,ErrBalanceTxUnableToCreateChange (ErrBalanceTxUnableToCreateChangeError {requiredCost = Coin 170737, shortfall = Coin 70737}) | ||
| 2.150000,ErrBalanceTxUnableToCreateChange (ErrBalanceTxUnableToCreateChangeError {requiredCost = Coin 170737, shortfall = Coin 20737}) | ||
| 2.000000,ErrBalanceTxUnableToCreateChange (ErrBalanceTxUnableToCreateChangeError {requiredCost = Coin 170561, shortfall = Coin 170561}) |
There was a problem hiding this comment.
Fee differences of 4 bytes in the error messages now reverted. Whether or not there were any other, less desriable changes to observable behaviour remains unclear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the switch made in the recent node bump out of precaution, as the behaviour of
estimateMinFeeTxis different from that ofevaluateTransactionFee.Task for later to properly address this: ADP-3334 (Stop using deprecated ledger function
Shelley.evaluateTransactionFee)Issue Number
ADP-3302, follow-up to #4503