Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review transaction ids golden tests (only new addresses) #452

Merged
merged 2 commits into from
Jun 22, 2019
Merged

Review transaction ids golden tests (only new addresses) #452

merged 2 commits into from
Jun 22, 2019

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Jun 21, 2019 •
edited
Loading

Issue Number

#219

⚠️ base branch is KtorZ/parameterize-tx ⚠️

Overview

  • I have re-generated golden tests using jcli for Mainnet and Testnet using only new addresses
  • I have added reproduction steps to the specs to make it easier for readers to also generate golden tests in the future.

Comments

@KtorZ KtorZ self-assigned this Jun 21, 2019
@KtorZ KtorZ force-pushed the KtorZ/transaction-id-golden-tests branch from e10f92b to 55cfa17 Compare June 21, 2019 20:58
@KtorZ KtorZ force-pushed the KtorZ/transaction-id-golden-tests branch from 55cfa17 to 8f5b202 Compare June 22, 2019 00:17
@KtorZ KtorZ mentioned this pull request Jun 22, 2019
Merged
2 tasks
akegalj
akegalj approved these changes Jun 22, 2019
View reviewed changes
Copy link
Contributor

@akegalj akegalj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lib/jormungandr/test/unit/Cardano/Wallet/Jormungandr/CompatibilitySpec.hs
-- echo ""
--
-- # One input, one output, one change
-- echo $ROOTPRV0 | jcli transaction make-witness $FAKEIN0 --genesis-block-hash $BLOCK0 --type utxo > /tmp/wit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@KtorZ KtorZ changed the base branch from KtorZ/parameterize-tx to master June 22, 2019 11:40
@KtorZ KtorZ force-pushed the KtorZ/transaction-id-golden-tests branch from 8f5b202 to 43f1aca Compare June 22, 2019 11:41
@KtorZ KtorZ merged commit 58657c4 into master Jun 22, 2019
@KtorZ KtorZ deleted the KtorZ/transaction-id-golden-tests branch June 22, 2019 12:36
@KtorZ KtorZ mentioned this pull request Jun 22, 2019
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akegalj akegalj akegalj approved these changes

@Anviking Anviking Awaiting requested review from Anviking

@paweljakubas paweljakubas Awaiting requested review from paweljakubas

Assignees

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KtorZ @akegalj