Scenarios for 0 amount tx for multi and single output for CLI and API #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
reviewed
Jun 24, 2019
| @@ -715,3 +715,34 @@ spec = do | |||
| [ expectResponseCode HTTP.status403 | |||
| , expectErrorMessage errMsg403InvalidTransaction | |||
| ] | |||
|
|
|||
| it "TRANS_CREATE_09 - 0 amount transaction is forbidden on multi-output tx" $ \ctx -> do | |||
| wSrc <- fixtureWalletWith ctx [10_000_000, 12_000_000] | |||
There was a problem hiding this comment.
What's the need for having the output defined as such? (asking because fixtureWalletWith needs to restore a 2 wallets & make two transactions, which is quite expensive (in terms of time) to do).
I don't think it's needed for the test here and, going for fixtureWallet should be enough, don't you think?
There was a problem hiding this comment.
OK, no particular reason for that. Will change to fixtureWallet.
piotr-iohk
force-pushed
the
piotr/cli_test_for_o_amount_tx
branch
from
c77a0c7
to
5d6855e
Compare
KtorZ
approved these changes
Jun 24, 2019
piotr-iohk
force-pushed
the
piotr/cli_test_for_o_amount_tx
branch
from
5d6855e
to
756cefd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#364
Overview
Comments