Allow BlockSyncer.listen to catch up with the node #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
force-pushed
the
rvl/52/catch-up
branch
2 times, most recently
from
66fb354
to
df20bbe
Compare
paweljakubas
approved these changes
Mar 15, 2019
| @@ -92,6 +94,9 @@ mkReader = do | |||
| , \x -> modifyMVar_ ref $ return . (x :) | |||
| ) | |||
|
|
|||
| flatten :: [TickResult [Block]] -> [Block] | |||
| flatten = concat . concat . map toList | |||
There was a problem hiding this comment.
maybe : concat . concatMap toList ?
There was a problem hiding this comment.
oh I see HLint complained about it. I will fix this, squash and push
paweljakubas
force-pushed
the
rvl/52/catch-up
branch
from
df20bbe
to
dd80953
Compare
KtorZ
reviewed
Mar 15, 2019
| data TickResult a | ||
| = GotChunk !a -- ^ Have a result, and there may be more available. | ||
| | Sleep -- ^ There is no result available now, so wait. | ||
| deriving (Show, Eq, Foldable) |
There was a problem hiding this comment.
I wonder how the Foldable instance is derived here 🤔
There was a problem hiding this comment.
{-# LANGUAGE DeriveFoldable #-}
KtorZ
approved these changes
Mar 15, 2019
|
Please don't merge now. I am trying to resolve issues with building the http bridge first. |
paweljakubas
force-pushed
the
rvl/52/catch-up
branch
from
dd80953
to
2751fc5
Compare
|
just rebased |
It will now process blocks continuously, in chunks, until all the local blocks from the node are done. Then it will start polling. [23] Hlint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #52.
Overview
It will now process blocks continuously, in chunks, until all the local blocks from the node are done. Then it will start polling.