Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA review of #8 #87

Merged
merged 3 commits into from
Mar 19, 2019
Merged

QA review of #8 #87

merged 3 commits into from
Mar 19, 2019

Conversation

piotr-iohk
Copy link
Contributor

Issue Number

Overview

  • I have corrected typo in POSIXSpec.md and added additional info
  • I have slightly modified test LauncherSpec.hs (just changed the order of commands in 1 test)

Comments

@piotr-iohk piotr-iohk self-assigned this Mar 19, 2019
@piotr-iohk piotr-iohk requested a review from KtorZ March 19, 2019 17:08
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

]
(ProcessHasExited name code) <- launch commands
name `shouldBe` cmdName (commands !! 0)
name `shouldBe` cmdName (commands !! 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rational here 😅 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just wanted to test different orders of commands added to the launcher... added few more test, because this alone didn't make any sense indeed :)

@piotr-iohk piotr-iohk merged commit c93b82b into master Mar 19, 2019
@piotr-iohk piotr-iohk deleted the piotr/8/qa-review branch March 19, 2019 18:10
jamescheuk91 pushed a commit to jamescheuk91/cardano-sl that referenced this pull request Mar 28, 2019
3930: [87] Copy `NodeStateAdaptor` from the wallet to the node r=KtorZ a=Anviking

## Description
We don't want to use NodeStateAdaptor from the wallet. We'd like to decouple the wallet from the node, and talk over an API (the Node API). To aid the transition, I have abruptly copied the wallet `NodeStateAdaptor` to the Node, so that it can serve the following additional protocol parameters in the node-settings endpoint:
- slotId
- slotCount
- maxTxSize
- feePolicy
- securityParameter
## Linked issue

cardano-foundation/cardano-wallet#87



Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants