More tests for byron wallets migration, in particular migrating from big wallets #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ UTxOs) with dust
piotr-iohk
approved these changes
Nov 6, 2019
There was a problem hiding this comment.
looks good.
Updated https://docs.google.com/spreadsheets/d/1fadIA_j4nCd3FbylPo5J8K9Fy6tixSC2T9V3xHKuUvU.
Few more tests could be added though, like verifying behavior when trying to migrate using faulty wallet ids (e.g. trying to migrate Shelly to Byron, or Byron to Byron, or Shelley to Shelley)
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 6, 2019
966: More tests for byron wallets migration, in particular migrating from big wallets r=piotr-iohk a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #779 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have added an extra integration scenario to test migrating a big wallet with a lot of dust - [x] I have revised byron migrate response behavior when trying to migrate an empty wallet to return a 403. Two reasons for this: this is more semantically correct. It prevents some extra code needed to handle possible errors that could have occurred if we indeed tried migrating (like, an invalid passphrase). - [x] enable a currently pending test in BYRON_TX_LIST which required faucet - [x] Added extra negative scenario to check migrating with a wrong passphrase - [x] Revised endpoints status in swagger.yaml + added missing error code in migration response # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Build succeeded |
| @@ -1314,7 +1316,7 @@ paths: | |||
| tags: ["Byron Transactions"] | |||
| summary: List | |||
| description: | | |||
| <p align="right">status: <strong>under testing</strong></p> | |||
| <p align="right">status: <strong>stable</strong></p> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#779
Overview
Comments