chore: migrated code to yaci-store rc1, updated pom, increased jdk ve… #47
Conversation
src/main/resources/application.yml
Outdated
| @@ -33,8 +33,8 @@ management: | |||
|
|
|||
| store: | |||
| cardano: | |||
| host: ${REMOTE_NODE_URL:relays-new.cardano-mainnet.iohk.io} | |||
| port: ${REMOTE_NODE_PORT:3001} | |||
| host: ${REMOTE_NODE_URL:192.168.68.113} | |||
There was a problem hiding this comment.
we may not want to check this in
There was a problem hiding this comment.
dang, this was an unwanted change, I was testing against my local node 🤦
pom.xml
Outdated
| @@ -132,6 +137,22 @@ | |||
| <groupId>org.springframework.boot</groupId> | |||
| <artifactId>spring-boot-maven-plugin</artifactId> | |||
| </plugin> | |||
| <!-- <plugin>--> | |||
There was a problem hiding this comment.
Why is this commented out?
| } | ||
|
|
||
| @Override | ||
| public int deleteBySlotGreaterThan(Long slot) { | ||
| public void saveSpent(List<TxInput> txInputs) { |
There was a problem hiding this comment.
What is the value of overwriting the same thing from the parent?
There was a problem hiding this comment.
None, it was just a leftover from live coding, good catch
| adaHandleHistoryService.rollbackToSlot(slot); | ||
| return super.deleteBySlotGreaterThan(slot); | ||
| return super.deleteUnspentBySlotGreaterThan(slot); |
There was a problem hiding this comment.
What is the value of overwriting the same thing from the parent?
There was a problem hiding this comment.
in this case you need both your custom code and the default code.
Indexer saves both set of relevant utxos following the default yaci-storage workflow and custom data.
There was a problem hiding this comment.
I still don't get it. You can delete this method and upper class will take care of things.
…rsion and spring boot version