feat: remove isPending in peerConnection metadata

cardano-foundation · May 8, 2024 · 1e55db1 · 1e55db1
1 parent 532b7d0
commit 1e55db1
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 16 deletions.
diff --git a/src/core/agent/records/peerConnectionMetadataRecord.test.ts b/src/core/agent/records/peerConnectionMetadataRecord.test.ts
@@ -9,7 +9,6 @@ const mockData: PeerConnectionMetadataRecordProps = {
   url: "url",
   iconB64: "icon",
   selectedAid: "aid",
-  isPending: false,
 };
 
 describe("Peer Connection Record", () => {
@@ -26,9 +25,6 @@ describe("Peer Connection Record", () => {
     expect(settingsRecord.url).toBe(mockData.url);
     expect(settingsRecord.selectedAid).toBe(mockData.selectedAid);
     expect(settingsRecord.iconB64).toBe(mockData.iconB64);
-    expect(settingsRecord.getTags()).toMatchObject({
-      isPending: mockData.isPending,
-    });
     expect(settingsRecord.createdAt).toBe(createdAt);
   });
 });
diff --git a/src/core/agent/records/peerConnectionMetadataRecord.ts b/src/core/agent/records/peerConnectionMetadataRecord.ts
@@ -5,14 +5,12 @@ interface PeerConnectionMetadataRecordProps {
   name?: string;
   url?: string;
   createdAt?: Date;
-  isPending?: boolean;
   iconB64?: string;
   selectedAid?: string;
 }
 
 class PeerConnectionMetadataRecord extends BaseRecord {
   name?: string;
-  isPending?: boolean;
   url?: string;
   iconB64?: string;
   selectedAid?: string;
@@ -27,7 +25,6 @@ class PeerConnectionMetadataRecord extends BaseRecord {
       this.id = props.id;
       this.name = props.name ?? "";
       this.url = props.url ?? "";
-      this.isPending = props.isPending ?? true;
       this.selectedAid = props.selectedAid ?? "";
       this.createdAt = props.createdAt ?? new Date();
       this.iconB64 = props.iconB64 ?? "";
@@ -37,7 +34,6 @@ class PeerConnectionMetadataRecord extends BaseRecord {
   getTags() {
     return {
       ...this._tags,
-      isPending: this.isPending,
     };
   }
 }

diff --git a/src/core/agent/records/peerConnectionStorage.test.ts b/src/core/agent/records/peerConnectionStorage.test.ts
@@ -19,7 +19,6 @@ const peerConnectionMetadataRecordProps = {
   url: "url",
   iconB64: "icon",
   selectedAid: "aid",
-  isPending: true,
   createdAt: new Date(),
 };
 
@@ -80,7 +79,7 @@ describe("Connection service of agent", () => {
     await peerConnectionStorage.updatePeerConnectionMetadata(
       peerConnectionMetadataRecord.id,
       {
-        isPending: false,
+        name: "update name",
       }
     );
     expect(storageService.update).toBeCalled();

diff --git a/src/core/agent/records/peerConnectionStorage.ts b/src/core/agent/records/peerConnectionStorage.ts
@@ -43,7 +43,7 @@ class PeerConnectionStorage {
     metadata: Partial<
       Pick<
         PeerConnectionMetadataRecord,
-        "name" | "url" | "iconB64" | "selectedAid" | "isPending"
+        "name" | "url" | "iconB64" | "selectedAid"
       >
     >
   ): Promise<void> {
@@ -55,8 +55,6 @@ class PeerConnectionStorage {
       identifierMetadataRecord.iconB64 = metadata.iconB64;
     if (metadata.selectedAid !== undefined)
       identifierMetadataRecord.selectedAid = metadata.selectedAid;
-    if (metadata.isPending !== undefined)
-      identifierMetadataRecord.isPending = metadata.isPending;
     await this.storageService.update(identifierMetadataRecord);
   }
 

diff --git a/src/core/agent/services/peerConnectionService.test.ts b/src/core/agent/services/peerConnectionService.test.ts
@@ -119,7 +119,6 @@ const peerConnectionMetadataRecordProps = {
   url: "url",
   iconB64: "icon",
   selectedAid: "aid",
-  isPending: true,
   createdAt: new Date(),
 };
 
@@ -165,7 +164,6 @@ describe("Peer connection service of agent", () => {
       url: "url1",
       iconB64: "icon1",
       selectedAid: "aid1",
-      isPending: true,
       createdAt: new Date(),
     };
     peerConnectionStorage.getPeerConnectionMetadata = jest

diff --git a/src/core/agent/services/peerConnectionService.ts b/src/core/agent/services/peerConnectionService.ts
@@ -36,7 +36,7 @@ class PeerConnectionService extends AgentService {
     identifier: string,
     data: Pick<
       PeerConnectionMetadataRecordProps,
-      "name" | "url" | "selectedAid" | "iconB64" | "isPending"
+      "name" | "url" | "selectedAid" | "iconB64"
     >
   ): Promise<PeerConnectionMetadataRecord> {
     await this.peerConnectionStorage.updatePeerConnectionMetadata(