Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add func get bran and check mnemonic #490

Conversation

Sotatek-BaoHoanga
Copy link
Collaborator

Description

Add function to get bran and check mnemonic valid

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [link]

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Sotatek-BaoHoanga and others added 2 commits May 23, 2024 12:18
* feat: add func migrate preferences storage to basic storage

* fix: unittest

* chore: fix error unittest

* chore: add unittest for biametry cache and indentifier view type cache

* chore: change location function createOrUpdate and some unittest

* chore: change misc record id name

* chore: change misc record name

* chore: change use biometryCacheCache

* chore: rm state and fix unittest
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-ot1t2v7nl.vercel.app

src/core/agent/agent.ts Outdated Show resolved Hide resolved
src/core/agent/agent.ts Outdated Show resolved Hide resolved
src/core/agent/agent.ts Outdated Show resolved Hide resolved
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-2jh37xwt1.vercel.app

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-dlptxv3vz.vercel.app

@Sotatek-BaoHoanga Sotatek-BaoHoanga changed the base branch from develop to feature/DTIS-895-secure-seed-phrase-generation-and-verify-process May 24, 2024 09:56
@Sotatek-BaoHoanga Sotatek-BaoHoanga merged commit e6423e6 into feature/DTIS-895-secure-seed-phrase-generation-and-verify-process May 27, 2024
2 checks passed
@iFergal iFergal deleted the feature/DTIS-927-adjust-creation-time-of-signify-bran branch May 27, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants