Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): pin ssi agent validate button to bottom of page #522

Conversation

Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Jun 14, 2024

Description

Pin validate button to bottom of Create SSI agent page

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: DTIS-971

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • [] Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

Screenshot 2024-06-14 at 15 56 36

Android

Screenshot 2024-06-14 at 15 28 23

Browser

Screenshot 2024-06-14 at 15 22 39

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-nq78s7nla.vercel.app

Copy link
Contributor

@sdisalvo-crd sdisalvo-crd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also fix “Create your password” page, I added a screenshot to the ticket on Jira to show it has the same issue.

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-b86ki6les.vercel.app

@Sotatek-DukeVu
Copy link
Collaborator Author

Could you please also fix “Create your password” page, I added a screenshot to the ticket on Jira to show it has the same issue.

I updated create password screen. Please help me check.

IOS

Screenshot 2024-06-17 at 09 47 33

Android

Screenshot 2024-06-17 at 09 55 40

Browser

Screenshot 2024-06-17 at 09 35 48

@Sotatek-DukeVu Sotatek-DukeVu force-pushed the fix/DTIS-971-make-ssi-agent-screen-cta-stuck-phone-bottom branch from f060538 to 8b60ff9 Compare June 17, 2024 08:47
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-l5nslgqqm.vercel.app

@Sotatek-DukeVu Sotatek-DukeVu force-pushed the fix/DTIS-971-make-ssi-agent-screen-cta-stuck-phone-bottom branch from 8b60ff9 to 8fa0c81 Compare June 17, 2024 08:58
@sdisalvo-crd sdisalvo-crd merged commit e9a2b61 into develop Jun 24, 2024
@sdisalvo-crd sdisalvo-crd deleted the fix/DTIS-971-make-ssi-agent-screen-cta-stuck-phone-bottom branch June 24, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants