Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): remove checkMultisigComplete #531

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

Sotatek-HocNguyena
Copy link
Collaborator

@Sotatek-HocNguyena Sotatek-HocNguyena commented Jun 20, 2024

Description

  • Remove checkMultisigComplete from the core as it’s no longer needed
  • Remove the pending click check from the UI

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: DTIS-974

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

@Sotatek-HocNguyena Sotatek-HocNguyena self-assigned this Jun 20, 2024
@Sotatek-HocNguyena Sotatek-HocNguyena marked this pull request as ready for review June 20, 2024 10:05
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-a3q2tldkn.vercel.app

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-e742sg6ea.vercel.app

@iFergal iFergal changed the title feat (core): remove checkMultisigComplete feat(core): remove checkMultisigComplete Jun 24, 2024
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-70ymhe8nd.vercel.app

src/ui/pages/Identifiers/Identifiers.tsx Show resolved Hide resolved
src/ui/pages/Identifiers/Identifiers.tsx Outdated Show resolved Hide resolved
src/ui/pages/Identifiers/Identifiers.tsx Outdated Show resolved Hide resolved
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-d7mkaj9z8.vercel.app

iFergal
iFergal previously approved these changes Jun 25, 2024
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-ids6wwy2v.vercel.app

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-hvbfh38pk.vercel.app

@iFergal iFergal merged commit b57ecbf into develop Jun 25, 2024
1 check passed
@iFergal iFergal deleted the feat/remove-check-multisig-complete branch June 25, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants