Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): multi sig rotation readiness in the core #592

Merged

Conversation

Sotatek-BaoHoanga
Copy link
Collaborator

@Sotatek-BaoHoanga Sotatek-BaoHoanga commented Jul 22, 2024

Description

Multi sig rotation readiness in the core

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: link

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-4ay4933hx.vercel.app

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-o8xlra2ua.vercel.app

@Sotatek-BaoHoanga Sotatek-BaoHoanga self-assigned this Jul 22, 2024
@Sotatek-BaoHoanga Sotatek-BaoHoanga marked this pull request as ready for review July 22, 2024 09:49
src/core/agent/services/multiSigService.ts Show resolved Hide resolved
src/core/agent/services/multiSigService.ts Outdated Show resolved Hide resolved
src/core/agent/services/multiSigService.ts Outdated Show resolved Hide resolved
src/core/agent/services/multiSigService.ts Outdated Show resolved Hide resolved
@Sotatek-BaoHoanga Sotatek-BaoHoanga changed the title Multi sig rotation readiness in the core feat(core): multi sig rotation readiness in the core Jul 22, 2024
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-avbzyesyj.vercel.app

src/core/agent/services/multiSigService.ts Outdated Show resolved Hide resolved
src/core/agent/services/multiSigService.ts Outdated Show resolved Hide resolved
src/core/agent/services/multiSigService.ts Outdated Show resolved Hide resolved
src/core/agent/services/multiSigService.test.ts Outdated Show resolved Hide resolved
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-5j7uob8q2.vercel.app

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-rnyibzd64.vercel.app

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-lug8y1aiz.vercel.app

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-90sqfc9hq.vercel.app

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-a1j88maxo.vercel.app

@iFergal iFergal merged commit e15809b into develop Jul 24, 2024
1 check passed
@iFergal iFergal deleted the feat/DTIS-1042-multi-sig-rotation-readiness-in-the-core branch July 24, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants