Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): archived or deleted credentials should not be presentable #597

Merged
merged 3 commits into from
Jul 24, 2024
Merged

feat(core): archived or deleted credentials should not be presentable #597

merged 3 commits into from
Jul 24, 2024

Conversation

Sotatek-BaoHoanga
Copy link
Collaborator

@Sotatek-BaoHoanga Sotatek-BaoHoanga commented Jul 24, 2024 •
edited
Loading

Description

Please include a summary of the changes and a brief description about this PR

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: link

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-e0mewzskr.vercel.app

@github-actions GitHub Actions
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-p4f74g5ra.vercel.app

@Sotatek-BaoHoanga Sotatek-BaoHoanga marked this pull request as ready for review July 24, 2024 06:49
@Sotatek-BaoHoanga Sotatek-BaoHoanga self-assigned this Jul 24, 2024
@iFergal iFergal merged commit 8b19543 into develop Jul 24, 2024
1 check passed
@iFergal iFergal deleted the feat/DTIS-1063-archived-or-deleted-credentials-should-not-be-presentable branch July 24, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iFergal iFergal iFergal approved these changes

Assignees

@Sotatek-BaoHoanga Sotatek-BaoHoanga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sotatek-BaoHoanga @iFergal