Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): prevent unable to connect toast to show with every conection #603

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jorgenavben
Copy link
Member

Description

Every time that a new connection was stablished using Cardano Connect a toast with the text unable to connect was showing up even if the connection was successfully stablished a few seconds later. This PR prevents this from happening.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue:

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)

@jorgenavben jorgenavben requested a review from iFergal July 24, 2024 15:12
Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-6t01h7i2w.vercel.app

@jorgenavben jorgenavben merged commit c5a1610 into develop Jul 24, 2024
1 check passed
@jorgenavben jorgenavben deleted the fix/unable-connect-toast-cip-45 branch July 24, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants