Update installing-cardano-node.md fixed commit for libsodium #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update installing-cardano-node.md fixed commit for libsodium now it should checkout on dbb48cc
Update installing-cardano-node.md for MAC too, now lets use correct commit for libsodium - dbb48cc
rphair
approved these changes
May 12, 2023
There was a problem hiding this comment.
matches commit ID in https://github.com/input-output-hk/cardano-node/releases/tag/8.0.0
rdlrt
approved these changes
May 13, 2023
There was a problem hiding this comment.
Might be good to add a comment about cabal clean - which will likely be required on an existing install if encountering an error with build (can keep it generic, without having to worry about error msg or version - as with CHaP and rushed releases becoming norm , those building binaries might need this frequently).
Otherwise , lgtm
fill-the-fill
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn buildafter adding my changes without getting any errors.Updating documentation or Bugfix
Updated installing-cardano-node.md fixed commit for libsodium now it should checkout on dbb48cc
Fixes #1055