Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-Chain Polls: Fix verify-poll parameter #1065

Merged

Conversation

weebl2000
Copy link
Contributor

@weebl2000 weebl2000 commented May 17, 2023

It's --tx-file, not --signed-tx-file

Checklist

  • I have read the How to Contribute.
  • I have run yarn build after adding my changes without getting any errors.

Updating documentation or Bugfix

image

It's --tx-file, not --signed-tx-file
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True enough, thanks 🤓

$ cardano-cli-8.0.0 governance verify-poll
Usage: cardano-cli-8.0.0 governance verify-poll --poll-file FILE
            --tx-file FILE
            [--out-file FILE]

@rphair rphair added the documentation Improvements or additions to documentation label May 17, 2023
@weebl2000
Copy link
Contributor Author

I spot a Nijntje!

@rphair rphair changed the title Fix verify-poll parameter On-Chain Polls: Fix verify-poll parameter May 17, 2023
@rphair
Copy link
Collaborator

rphair commented May 17, 2023

correct, it's from the cover of Miffy the Artist (English title); I edited out the paintbrush 🐰

@rphair
Copy link
Collaborator

rphair commented May 17, 2023

@katomm @os11k @rdlrt @fill-the-fill getting some traffic from https://forum.cardano.org/t/entering-voltaire-on-chain-poll-for-spos/117330/38 so will have to push this out soon.

@fill-the-fill fill-the-fill merged commit e3a6cdc into cardano-foundation:staging May 17, 2023
3 checks passed
@rphair
Copy link
Collaborator

rphair commented May 21, 2023

I figured out how this error came about... the option was --signed-tx-file in the backport. I guess since 8.0.0 uses the more canonically named option it will completely supersede the backport in time, so there's no benefit complicating the instructions by explaining how the backport works differently. @rdlrt @os11k @fill-the-fill @katomm maybe let me know if you think otherwise & I'll update the instructions for both cases.

$ cardano-cli-8.0.0 governance verify-poll --poll-file poll.json --tx-file vote.signed
Found valid poll answer with 1 signatories
[
    "c94e6fe1123bf111b77b57994bcd836af8ba2b3aa72cfcefbec2d3d4"
]
$ cardano-cli-1.35.7+cip-0094 governance verify-poll --poll-file poll.json --tx-file vote.signed
Invalid option `--tx-file'

Usage: cardano-cli-1.35.7+cip-0094 governance verify-poll --poll-file FILE
            --signed-tx-file FILE

  Verify an answer to a given SPO poll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants