-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Registering a Pool to stake pool documentation #1066
Conversation
replaced register-stake-pool-metadata.md with register-stake-pool.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to have these additions back in the staging
workflow... but now more people will have to review them 🤓
Sorry for nitpicking, but does TinyURL work okay with GitHub? Can we upload poolmetadata to GitHub and then shorten the URL with TinyURL? I thought when git.io stopped accepting new URLs, GitHub was no longer suitable for pool metadata. |
Added info about case when we need to configure multiple relays
@os11k I have no idea about the GitHub blocking the redirect URI since personally I would never use anything but a static URL for pool metadata. But I have seen it recommended in other Cardano setup guides & therefore haven't discriminated against it here. @sanskys can you verify that TinyURL in fact works with GitHub in your own testnet environment? Also @os11k good idea to add the syntaxes in a2bd26e here... I remember needing to know that in the early days & having to confirm it on the Forum so it's good to have it all in one place. |
I'm thinking to add details how to create transaction with simple copy-paste commands(query UTXOs and etc), so we don't need to calculate fees as it is now in manually:
Yes, seems tinyurl should work, as it is recommended by others... |
minor change, updated description regarding multiple relays
tiny url works fine. Better would be obviously to store it where the url length is small |
@sanskys I assumed this was going into @fill-the-fill @katomm I guess that means this PR has to be re-submitted? We have work from 3 different contributors in this PR so it would be nice if there were a way at the admin UI of flopping over the target from Or: I just made a current local copy of this @sanskys branch |
Yeah, I've missed that part too..We can't merge it into |
@sanskys as the submitter I guess it is up to you to do that, since at the contributor level I don't have this option. 🤓 https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request |
OK, it let me do it in the heading of this PR (only submitter can change it from their own fork's UI I think). 😎 |
Checklist
yarn build
after adding my changes without getting any errors.Updating documentation or Bugfix
Replacing register-stake-pool-metadata.md with register-stake-pool.md