Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update register-stake-pool.md, lets use protocol.json everywhere #1096

Merged
merged 6 commits into from
Jun 26, 2023

Conversation

os11k
Copy link
Collaborator

@os11k os11k commented Jun 25, 2023

Checklist

  • I have read the How to Contribute.
  • I have run yarn build after adding my changes without getting any errors.

Updating documentation or Bugfix

Update register-stake-pool.md, lets use protocol.json here as everywhere else instead of params.json, this will introduces a bit more consistency.

Update register-stake-pool.md, lets use protocol.json everywhere, instead of params.json
@os11k os11k marked this pull request as ready for review June 25, 2023 10:57
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also wanted to update that at the last review of this document, but was of a mixed mind about it. I think avoiding potential questions like "how are these files different?" is more important than the license to assign an arbitrary name for this file.

…script and the tx-in will be automatically populated too.

Update register-stake-pool.md - Now we will get the balance from the script and the tx-in will be automatically populated too.
@os11k
Copy link
Collaborator Author

os11k commented Jun 25, 2023

Sorry, @rphair , for those multiple commits even after I marked this PR as ready for review. I just found a bit more time today than expected and decided to add those bits too. It is still, in my opinion, work in progress, but I will leave it as it is for now. Maybe later I will get a bit more time, but then it will go in a separate PR. Again, sorry for this mess. Cheers!

@rphair
Copy link
Collaborator

rphair commented Jun 25, 2023

multiple commits even after I marked this PR as ready for review

😎 no problem, still looks good ✔️

Update register-stake-pool.md - removed * in if for UTXO script

I had * for my environment, where * is necessary, because after redirecting output from Docker to local files, it seems to add a /r at the end of the fullUtxo.out file. This is not necessary here, as most users will not be using Docker.
@os11k
Copy link
Collaborator Author

os11k commented Jun 25, 2023

this is a lost one, I promise.... I removed * from IF in UTXO script. I had * for my environment, where * is necessary, because after redirecting output from Docker to local files, it seems to add a /r at the end of the fullUtxo.out file. This is not necessary here, as most users will not be using Docker.

@rphair
Copy link
Collaborator

rphair commented Jun 25, 2023

fine with me ✔️ and I also realised it would drive me crazy if not removing the - (from the machine readable command option) from the human readable English expression "protocol parameters" 🤓

@fill-the-fill fill-the-fill merged commit e145f28 into staging Jun 26, 2023
4 checks passed
@fill-the-fill fill-the-fill deleted the os11k-patch-1 branch June 26, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants