-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update register-stake-pool.md, lets use protocol.json everywhere #1096
Conversation
Update register-stake-pool.md, lets use protocol.json everywhere, instead of params.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also wanted to update that at the last review of this document, but was of a mixed mind about it. I think avoiding potential questions like "how are these files different?" is more important than the license to assign an arbitrary name for this file.
…script and the tx-in will be automatically populated too. Update register-stake-pool.md - Now we will get the balance from the script and the tx-in will be automatically populated too.
Sorry, @rphair , for those multiple commits even after I marked this PR as ready for review. I just found a bit more time today than expected and decided to add those bits too. It is still, in my opinion, work in progress, but I will leave it as it is for now. Maybe later I will get a bit more time, but then it will go in a separate PR. Again, sorry for this mess. Cheers! |
😎 no problem, still looks good ✔️ |
Update register-stake-pool.md - removed * in if for UTXO script I had * for my environment, where * is necessary, because after redirecting output from Docker to local files, it seems to add a /r at the end of the fullUtxo.out file. This is not necessary here, as most users will not be using Docker.
this is a lost one, I promise.... I removed * from IF in UTXO script. I had * for my environment, where * is necessary, because after redirecting output from Docker to local files, it seems to add a /r at the end of the fullUtxo.out file. This is not necessary here, as most users will not be using Docker. |
fine with me ✔️ and I also realised it would drive me crazy if not removing the |
Checklist
yarn build
after adding my changes without getting any errors.Updating documentation or Bugfix
Update register-stake-pool.md, lets use protocol.json here as everywhere else instead of params.json, this will introduces a bit more consistency.