Change witness count to 2 for minting transactions #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You sign with payment key and policy key, so I guess the witness count should be 2 for those transactions instead of 1?
|
I need to summon @AndrewWestberg and @ruttkowa for this PR. (see also #323) |
|
a duplicate of #323 |
|
Sorry, opening this up again, as it is a different file. Thanks @brouwerQ |
katomm
approved these changes
Oct 7, 2021
katomm
added a commit
that referenced
this pull request
Oct 8, 2021
…347) * Add cardano-wallet-js (#313) * cardano-wallet-js * fix description * fix comments * include tags and fix typo * adapt get started page to styling guide Co-authored-by: javiertc * update instructions for cardano-wallet 2021.09.09 (#319) * Minor correction (#344) * Update node checkout references, replace home directory references (#341) * Change witness count to 2 for minting transactions (#322) You sign with payment key and policy key, so I guess the witness count should be 2 for those transactions instead of 1? * Change witness count to 2 for minting transactions (#323) You sign with payment key and policy key, so I guess the witness count should be 2 for those transactions instead of 1? * Fixes documentation Stake Pool Course Handbook (#342) Fixes documentation Stake Pool Course Handbook "Register stake pool keys" chapter. Instead of keyDeposit it should be stakeAddressDeposit. * Fix captcha issue raised in #339 (#346) Co-authored-by: Leobel Izquierdo Co-authored-by: Dan Loewenherz Co-authored-by: Ganesh Co-authored-by: Priyank Co-authored-by: brouwerQ Co-authored-by: Jurijs I
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You sign with payment key and policy key, so I guess the witness count should be 2 for those transactions instead of 1?