Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minting-nft to use transction build command #377

Merged
merged 3 commits into from
Nov 18, 2021

Conversation

mzfr
Copy link
Contributor

@mzfr mzfr commented Oct 18, 2021

Description of the change

Updated the minting-nft page. It was using the old transaction build-raw command. I feel that now transaction build works it's better to use that command. It helps to skip the fee calculation step.

Let me know if anything else has to be updated or changed.

Copy link
Collaborator

@rdlrt rdlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. Just a minor grammatical change request, but otherwise looks good

docs/native-tokens/minting-nfts.md Outdated Show resolved Hide resolved
@katomm
Copy link
Member

katomm commented Oct 28, 2021

Any update/opinions on the rewording @mzfr? Thank you

@mzfr
Copy link
Contributor Author

mzfr commented Oct 30, 2021

@katomm I left the following comment:

Actually, I added IF here because say the output value set above doesn't give any Minimum UTxO error then that would mean it worked and there is no issue.

Please let me know your thoughts on this. If you feel this should be changed, then I'll reword it :)

@katomm
Copy link
Member

katomm commented Nov 3, 2021

Hey, @mzfr this was not about right or wrong. From my text feeling, I would go with @rdlrt's suggestion but I'm not a native speaker. I just wanted to know if there are more changes.

@mzfr
Copy link
Contributor Author

mzfr commented Nov 3, 2021

Oh okay, no problem.
I'll make the suggested changes as soon as possible :)

Co-authored-by: Priyank <3169068+rdlrt@users.noreply.github.com>
@mzfr
Copy link
Contributor Author

mzfr commented Nov 4, 2021

@rdlrt @katomm I've made the suggested changes

@katomm
Copy link
Member

katomm commented Nov 11, 2021

Hello, possible to resolve the conflict so that we can merge this? Thank you.

@mzfr
Copy link
Contributor Author

mzfr commented Nov 11, 2021

@katomm Conflict should be resolved now.

@katomm katomm merged commit b58c17d into cardano-foundation:staging Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants