Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installing-cardano-wallet.md for Linux #420

Merged
merged 2 commits into from
Nov 25, 2021
Merged

Update installing-cardano-wallet.md for Linux #420

merged 2 commits into from
Nov 25, 2021

Conversation

os11k
Copy link
Collaborator

@os11k os11k commented Nov 23, 2021

Updating documentation

Description of the change

Updated Linux installation manual for cardano-wallet. Now we will use stack for building cardano-wallet, what seems recommended way to do this it we look here: https://input-output-hk.github.io/cardano-wallet/developers/Building

Updated Linux installation for cardano-wallet. Now we will use stack for building cardano-wallet, what seems recommended way to do this it we look here: https://input-output-hk.github.io/cardano-wallet/developers/Building
Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @os11k for updating this. I'd like to flag that technically this will work 1:1 for macOS. Only that this line:
cp -p ./lib/shelley/.stack-work/dist/x86_64-linux-/Cabal-/build/cardano-wallet/cardano-wallet $HOME/.local/bin/

Needs to be replaced with:
p -p ./lib/shelley/.stack-work/dist/x86_64-osx/Cabal-*/build/cardano-wallet/cardano-wallet $HOME/.local/bin/

Therefore I'm wondering if it still makes sense to split Linux/macOS like you did.

@os11k
Copy link
Collaborator Author

os11k commented Nov 24, 2021

I do have mac near me and I even tried to compile it yesterday, unfortunately somehow it didn't went well. I'm still not aware what went wrong. Maybe later I will find time for this. I would assume same, that it should work as you proposed. Working with physical computers is pain in ass and rent mac in AWS is like 1000$ a hour. :(

@katomm
Copy link
Member

katomm commented Nov 24, 2021

@os11k I have verified it myself. (macOs intel architecture)

@os11k
Copy link
Collaborator Author

os11k commented Nov 24, 2021

I will update pull request later this week so we will have MacOS & Linux same as it was before in one paragraph only with newest commands from me. If it worked for you, then I would expect that there no need to split it. I tested it on M1, maybe that why it didn't compile properly.

Merged Linux & MacOS manuals together as requested by @katomm
@os11k
Copy link
Collaborator Author

os11k commented Nov 24, 2021

Hi @katomm ! I updated as you proposed. Cheers!

Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@os11k awesome, thank you.

Copy link
Collaborator

@rdlrt rdlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as the dev-portal will be following respective repository's recommendation.

My only hesitation is at target itself (on cardano-wallet repo), as most other builder facing IOG components use cabal as recommended approach - but the wallet repo stands out with alternate instructions resulting in builders having to cater for different system requirements.

In ideal scenario, we could have both the versions - but that could be confusing to read (and in addition, if specific team does not include cabal as part of e2e testing - it might not be worth the additional effort on docs).

@katomm katomm merged commit ff825bb into cardano-foundation:staging Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants