Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grafana Tutorial: Adding Chapter 8 on Leadership Schedule and including Screenshots #552

Merged
merged 6 commits into from
Mar 14, 2022
Merged

Grafana Tutorial: Adding Chapter 8 on Leadership Schedule and including Screenshots #552

merged 6 commits into from
Mar 14, 2022

Conversation

sanskys
Copy link
Contributor

@sanskys sanskys commented Mar 9, 2022 •
edited
Loading

Updating documentation

@sanskys sanskys changed the title Adding Chapter 8 on Leadership Schedule and including Screenhots Adding Chapter 8 on Leadership Schedule and including Screenshots Mar 9, 2022
@sanskys sanskys changed the title Adding Chapter 8 on Leadership Schedule and including Screenshots Grafana Tutorial: Adding Chapter 8 on Leadership Schedule and including Screenshots Mar 9, 2022
katomm
katomm requested changes Mar 9, 2022
View reviewed changes
Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, put please put in the open graph image again (or change it if you prefer)
I mean:
image: ./img/og-developer-portal.png

it generated the site previews for many social sites.

@sanskys
Copy link
Contributor Author

sanskys commented Mar 9, 2022

Great, put please put in the open graph image again (or change it if you prefer) I mean: image: ./img/og-developer-portal.png

it generated the site previews for many social sites.

ok..i understand...adding it back

@sanskys sanskys requested a review from katomm March 9, 2022 16:55
katomm
katomm approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fill-the-fill
fill-the-fill approved these changes Mar 11, 2022
View reviewed changes
Copy link
Collaborator

@fill-the-fill fill-the-fill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sanskys
sanskys commented Mar 11, 2022
View reviewed changes
Copy link
Contributor Author

@sanskys sanskys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed as discussed

docs/stake-pool-course/handbook/grafana-dashboard-tutorial.md Show resolved Hide resolved
@katomm katomm merged commit 522b4cc into cardano-foundation:staging Mar 14, 2022
Mercurial pushed a commit to ADAPhilippines/developer-portal that referenced this pull request Mar 15, 2022
@sanskys @Mercurial
Grafana Tutorial: Adding Chapter 8 on Leadership Schedule and includi…
a8a578a 
…ng Screenshots (cardano-foundation#552)

* Update grafana-dashboard-tutorial.md

* Add files via upload

* Update grafana-dashboard-tutorial.md

* Update grafana-dashboard-tutorial.md

* Update grafana-dashboard-tutorial.md

* Update grafana-dashboard-tutorial.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdlrt rdlrt rdlrt approved these changes

@katomm katomm katomm approved these changes

@fill-the-fill fill-the-fill fill-the-fill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sanskys @rdlrt @katomm @fill-the-fill