Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify build scripts: Replace fs.rmdir with fs.rm #692

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Modify build scripts: Replace fs.rmdir with fs.rm #692

merged 1 commit into from
Jul 15, 2022

Conversation

fill-the-fill
Copy link
Collaborator

In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed.

@fill-the-fill fill-the-fill added the script Improvements or additions of scripts label Jul 12, 2022
rphair
rphair approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - https://nodejs.org/api/deprecations.html#DEP0147

@katomm katomm merged commit e41c93d into cardano-foundation:staging Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphair rphair rphair approved these changes

@rdlrt rdlrt rdlrt approved these changes

@katomm katomm katomm approved these changes

Assignees
No one assigned
Labels
script Improvements or additions of scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fill-the-fill @rphair @rdlrt @katomm @fickevics-makor