Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify announcement bar to be closable #707

Merged
merged 1 commit into from Jul 26, 2022
Merged

Modify announcement bar to be closable #707

merged 1 commit into from Jul 26, 2022

Conversation

fill-the-fill
Copy link
Collaborator

@fill-the-fill fill-the-fill commented Jul 25, 2022 •
edited

Modify announcement bar to be closable

rphair
rphair approved these changes Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting @KtorZ's comment that the survey is running through the 29th (4 more days from now) (#704 (comment)) but does not say the bar cannot be closable before then; only that it should remain there. 🤔

@fill-the-fill
Copy link
Collaborator Author

Just noting @KtorZ's comment that the survey is running through the 29th (4 more days from now) (#704 (comment)) but does not say the bar cannot be closable before then; only that it should remain there. 🤔

I believe in case someone already did the survey, it would be annoying to constantly see the announcement bar on top

@rphair
Copy link
Collaborator

rphair commented Jul 25, 2022

in case someone already did the survey, it would be annoying to constantly see the announcement bar

I agree & have display: none'd web site components in browser style sheets for less... it would be a shame for people to have to do that to the Developer Portal 💔

@KtorZ
Copy link
Member

KtorZ commented Jul 26, 2022

Note that the survey is ending tomorrow. So we might as well remove the bar 😅

katomm
katomm approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, they should always be closeable.

@katomm katomm merged commit 0eba694 into cardano-foundation:staging Jul 26, 2022
@katomm
Copy link
Member

katomm commented Jul 26, 2022

So we might as well remove the bar

Fine to remove a closeable bar. ☝️😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphair rphair rphair approved these changes

@rdlrt rdlrt rdlrt approved these changes

@katomm katomm katomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fill-the-fill @rphair @KtorZ @katomm @rdlrt @fickevics-makor