VOID0 the GPOOL ticker to update pk in PR #408 #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to only change 2 files
|
Submitting only the 2 new files, with a request to remove the old ones would not work either as it flags the "like ticker" error. |
|
This is a bug with the way your running checks, old sig file and new sig file are counted as 2 different files bc the way you have us label the sig file and the file only has 1 line in it. It is looked at as a new file rather then changing a file already merged, like the json file is. This results in a fail due to 3 files being involved,
|
Vetro7
changed the title
Closed
Vetro7
changed the title
|
Please now merge #408 after this one |
Vetro7
changed the title
cf-stevew
approved these changes
Dec 13, 2019
cf-stevew
added a commit
that referenced
this pull request
Dec 13, 2019
Now updates the GPOOL pk after VOID0 the ticker from #337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will continue to fail, it keeps counting old sig file as 3rd file changed, due to the PR already being merged #24 . Please just confirm all other checks pass and merge. This will be a problem for future PR that change already merged signatures with new public keys.