Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALOHA #520

Closed
wants to merge 5 commits into from
Closed

ALOHA #520

wants to merge 5 commits into from

Conversation

cardanohawaiipool
Copy link
Contributor

Please delete my currently merged (incorrect) ALOHA pool. Then please review this pull request and merge.

Thanks.

cardanohawaiipool and others added 5 commits December 14, 2019 13:44
@cardanohawaiipool
ALOHA
cb2a9bb 
Please delete the my currently merged (incorrect) ALOHA pool. Then please review this pull request and merge.

Thanks.
@cf-stevew
Merge branch 'master' into master
765971c
@cardanohawaiipool
VOID2
b7810a8 
Void previous PR#199 to allow PR #520 to use the ALOHA ticker and new public key. 

Thank you. I apologize for the confusion. I am not used to using github and no one seemed to know how to fix this problem. I appreciate that this makes things more secure for changing public key/private key.
@cardanohawaiipool
Delete old json
8897e0d
@cardanohawaiipool
Delete old sig
de4ab02
cardanohawaiipool added a commit to cardanohawaiipool/incentivized-testnet-stakepool-registry that referenced this pull request Dec 16, 2019
@cardanohawaiipool
ALOHA ticker --> VOID2
bee3261 
New commit to remove ALOHA ticker and replace with VOID2 to designate for removal. Please void PR#199. It will be replaced with PR cardano-foundation#520.

I hope I did this right. Sorry for any confusion. 

I really do appreciate all the security in place to make sure stakepools can not be changed without some confirmation. 

Thank you for your hard work.
@cardanohawaiipool cardanohawaiipool mentioned this pull request Dec 16, 2019
Merged
@cardanohawaiipool
Copy link
Contributor Author

PR #645 will void ALOHA pool which was created in PR #199.

This will be replaced by PR #520.

@admin-cf-2
Copy link
Contributor

Closing this PR because I guess it’s no longer relevant.

@admin-cf-2 admin-cf-2 closed this Dec 17, 2019
@cardanohawaiipool
Copy link
Contributor Author

Please reopen and merge this request.

I needed to remake my ticket, so I followed these directions:

#641

The original PR#199 was incorrect, so I created this one, #520. However, because they have the same ticker, I had to use PR #645 to change the old ticker to VOID2. By doing this, it would allow current ticker and key of PR #520 to be merged.

Thanks. Sorry for any confusion.

@cardanohawaiipool
Copy link
Contributor Author

Tagging @admin-cf-2 because I wasn't sure you would monitor closed requests.

@admin-cf-2
Copy link
Contributor

I'm sorry but I can not open this pull request again, because you deleted the repo that submitted this pull request. @cardanohawaiipool

@cardanohawaiipool
Copy link
Contributor Author

cardanohawaiipool commented Dec 17, 2019 •
edited
Loading

It is possible to just delete the files related to this closed pull request so I can resend a new PR?

I really apologize for all these problems I've caused.

@admin-cf-2

@cardanohawaiipool
Copy link
Contributor Author

Apologies, I will just send a PR to delete the json and sig files. Then submit another PR with the information again.

I think this is the best way to do it.

@admin-cf-2

This was referenced Dec 18, 2019
Closed
Closed
@admin-cf-2
Copy link
Contributor

Apologies, I will just send a PR to delete the json and sig files. Then submit another PR with the information again.

I think this is the best way to do it.

@admin-cf-2

Okay thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cardanohawaiipool @admin-cf-2 @cf-stevew