-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PostTxOnChainFailed
happens sometimes on concurrent Init
and Fanout
#832
Comments
The logs are about the Fanout case so we only analyse this case in the following.
Looking at the log to find what are the
When looking at the failureReason we see the following:
This transaction is missing an input as shown by This kind of error is expected: if all the nodes try to post the Fanout transaction at the same time then In your text you mention that you see Cheers, |
Sorry, you are right, nodes actually got But I still think this is wrong API behavior. I think if Tx fail on Hydra side is okay in some case - it should not return internal details but return some client-side understandable message. |
Of course @uhbif19 , you're right. The hydra-node is really not kind with you in this situation. I'll close this bug in favor of #839 which idea is to see if and how we can, indeed, improve this feedback. Also, this makes perfect sense to me for simultaneous Fanout (but with a lame feedback, I agree) but I would expect something quite different from simultaneous Init. So, just in case you observe strange things with Init, please raise an issue. |
Context & versions
hydra-node
is dockerizedghcr.io/input-output-hk/hydra-node:0.9.0
https://github.com/input-output-hk/hydra
with tagdf3f84863028ec4ab5f09b6ac2423b10cbc8d988
But we do construct commands JSONs ourselves: https://github.com/mlabs-haskell/hydra-auction/blob/staging/src/HydraAuction/Hydra/Interface.hs#L25
Steps to reproduce
I get
PostTxOnChainFailed
couple of times onInit
andFanout
. I think this may be related to that this commands are send concurrently. But I could not reproduce that in tests (in which I am sending concurrent requests just the same) or any other reliable way.But our probable usecase is this:
Init
command concurrently from threehydra-node
clients(or
Fanout
- seems like the same error ocures)Actual behavior
PostTxOnChainFailed
to allhydra-node
clientsLog for one of
hydra-node
s, cut after fail (forFanout
case): hydra-1-cut.txt.gzExpected behavior
Init
commandHeadIsInitializing
CommandFailed
for second and thirdInit
commandThe text was updated successfully, but these errors were encountered: