Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-node: 8.9.0 -> 8.11.0-pre #1439

Merged
merged 1 commit into from
May 27, 2024
Merged

cardano-node: 8.9.0 -> 8.11.0-pre #1439

merged 1 commit into from
May 27, 2024

Conversation

locallycompact
Copy link
Contributor

@locallycompact locallycompact commented May 17, 2024

Updates cardano-node to 8.11 and cardano-api to 8.46.


  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

@locallycompact locallycompact force-pushed the cardano-node-8.11 branch 13 times, most recently from aac65fc to 7181495 Compare May 19, 2024 08:54
@locallycompact locallycompact requested a review from ch1bo May 19, 2024 09:31
@locallycompact locallycompact force-pushed the cardano-node-8.11 branch 8 times, most recently from e29040a to d8b2706 Compare May 20, 2024 14:16
Copy link

github-actions bot commented May 20, 2024

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2024-05-27 14:20:48.781538711 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial baafeb5dc37bbe6e068784746bda0a3b1bb1d034fa0c55270f6079c1 4082
νCommit fe7af84822bcba542fae377ae7311fc5fd20152f925ccd980f73ecdc 2061
νHead 93c08c55e804d7f82ca545a01883b5fda6a6d3623cb78885625800ae 9366
μHead 5e65c73722b4bb3f0cbfcc8433e1dcdfea099eaf0a43060f1731a65b* 4237
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per Head.

Cost of Init Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 4818 5.89 2.31 0.43
2 5017 7.38 2.90 0.45
3 5220 8.69 3.42 0.47
5 5624 11.39 4.48 0.52
10 6626 18.40 7.24 0.64
58 16278 85.92 33.87 1.80

Cost of Commit Transaction

This is using ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 559 9.69 3.82 0.28
2 749 12.48 5.10 0.32
3 931 15.33 6.40 0.36
5 1309 21.26 9.09 0.45
10 2239 37.35 16.27 0.67
25 5052 96.42 41.75 1.45

Cost of CollectCom Transaction

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 544 14.78 5.90 0.34
2 114 654 22.85 9.25 0.43
3 170 764 33.31 13.59 0.55
4 225 874 44.24 18.21 0.68
5 283 984 58.01 23.97 0.84
6 337 1095 72.41 30.10 1.00
7 395 1205 90.37 37.65 1.20

Cost of Close Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 591 8.31 4.60 0.28
2 619 8.49 4.10 0.28
3 903 10.04 7.02 0.32
5 1246 11.93 9.52 0.37
10 2185 17.57 16.64 0.51
50 7716 48.75 61.57 1.33

Cost of Contest Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 615 8.60 4.71 0.28
2 817 9.73 6.14 0.31
3 902 10.26 7.01 0.32
5 1305 12.76 10.01 0.38
10 2108 16.91 15.95 0.49
50 8066 51.86 63.68 1.38

Cost of Abort Transaction

Some variation because of random mixture of still initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 4689 17.04 7.37 0.55
2 4860 28.62 12.55 0.69
3 4972 42.17 18.52 0.84
4 5086 53.46 23.40 0.97
5 5267 77.58 34.18 1.26
6 5317 96.99 42.64 1.48

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
5 0 0 4651 7.61 3.18 0.44
5 1 57 4686 8.97 3.98 0.46
5 5 285 4821 13.37 6.74 0.52
5 10 568 4989 19.55 10.48 0.60
5 20 1140 5331 30.66 17.43 0.76
5 30 1707 5670 42.40 24.66 0.92
5 40 2277 6010 54.14 31.88 1.08
5 50 2848 6352 65.77 39.06 1.24
5 80 4554 7368 99.91 60.30 1.72

End-To-End Benchmark Results

This page is intended to collect the latest end-to-end benchmarks results produced by Hydra's Continuous Integration system from the latest master code.

Please take those results with a grain of salt as they are currently produced from very limited cloud VMs and not controlled hardware. Instead of focusing on the absolute results, the emphasis should be on relative results, eg. how the timings for a scenario evolve as the code changes.

Generated at 2024-05-27 14:04:01.121261926 UTC

Baseline Scenario

Number of nodes 1
Number of txs 3000
Avg. Confirmation Time (ms) 4.680323450
P99 9.169047159999995ms
P95 5.684149849999999ms
P50 4.149019ms
Number of Invalid txs 0

Three local nodes

Number of nodes 3
Number of txs 9000
Avg. Confirmation Time (ms) 22.053369785
P99 104.1285642700003ms
P95 29.432220349999984ms
P50 19.6302565ms
Number of Invalid txs 0

@locallycompact locallycompact force-pushed the cardano-node-8.11 branch 6 times, most recently from 4d223c8 to c5ba8ae Compare May 22, 2024 11:41
@locallycompact locallycompact force-pushed the cardano-node-8.11 branch 2 times, most recently from ebb8006 to a174f8e Compare May 22, 2024 11:48
@locallycompact locallycompact force-pushed the cardano-node-8.11 branch 4 times, most recently from 4571e99 to d4bda41 Compare May 23, 2024 08:56
Copy link
Collaborator

@ch1bo ch1bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but the version checks are still misaligned on this branch.

Also, I'd like to request that note on the changelog to ensure we don't release with this cardano-node version (it's not supported on mainnet and testnet configs are off too).

Furthermore, please consider "less costly" imports as commented below.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
hydra-node/src/Hydra/Chain/Direct/Tx.hs Outdated Show resolved Hide resolved
hydra-node/src/Hydra/Chain/Direct/Tx.hs Outdated Show resolved Hide resolved
@locallycompact locallycompact force-pushed the cardano-node-8.11 branch 3 times, most recently from fdc288e to 39ff6cd Compare May 24, 2024 13:18
@locallycompact locallycompact requested a review from ch1bo May 24, 2024 13:49
@locallycompact locallycompact force-pushed the cardano-node-8.11 branch 5 times, most recently from caf79fb to 245a284 Compare May 27, 2024 06:41
Copy link

github-actions bot commented May 27, 2024

Test Results

427 tests  ±0   415 ✅  - 4   14m 24s ⏱️ - 1m 3s
139 suites ±0    12 💤 +4 
  2 files   ±0     0 ❌ ±0 

Results for commit 67d791d. ± Comparison against base commit 1255222.

This pull request skips 5 and un-skips 1 tests.
Test.CardanoNode ‑ withCardanoNodeOnKnownNetwork starts synchronizing within 10 seconds (Mainnet)
Test.CardanoNode ‑ withCardanoNodeOnKnownNetwork starts synchronizing within 10 seconds (Preproduction)
Test.CardanoNode ‑ withCardanoNodeOnKnownNetwork starts synchronizing within 10 seconds (Preview)
Test.CardanoNode/findRunningCardanoNode ‑ returns Just running node on matching network
Test.CardanoNode/findRunningCardanoNode ‑ returns Nothing on non-matching network
Test.CardanoNode ‑ withCardanoNodeOnKnownNetwork starts synchronizing within 10 seconds (Sanchonet)

♻️ This comment has been updated with latest results.

@locallycompact locallycompact requested a review from a team May 27, 2024 07:24
@locallycompact locallycompact merged commit aeb17ef into master May 27, 2024
19 checks passed
@locallycompact locallycompact deleted the cardano-node-8.11 branch May 27, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants